Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Brave" in "Show Brave suggested sites in autocomplete suggestions" description #12799

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

Tonev
Copy link
Contributor

@Tonev Tonev commented Mar 29, 2022

This commit removes "Brave" in "Show Brave suggested sites in autocomplete suggestions" description.

Resolves brave/brave-browser#16797

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

…tions"

This commit removes "Brave" in "Show Brave suggested sites in autocomplete suggestions" description.
@Tonev
Copy link
Contributor Author

Tonev commented Mar 29, 2022

Asking for assistance for review/merge whenever appropriate.

@stephendonner @bbondy @bsclifton

@bsclifton bsclifton self-requested a review April 1, 2022 22:51
@bsclifton bsclifton requested a review from mkarolin April 1, 2022 22:52
@bsclifton
Copy link
Member

cc: @mkarolin - I think this file (or at least this part of the file) is auto-generated. It might need to be replaced in another spot

@mkarolin
Copy link
Collaborator

mkarolin commented Apr 1, 2022

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tonev
Copy link
Contributor Author

Tonev commented Apr 2, 2022

Thank you, @bsclifton and @mkarolin! Please, remember to merge as well when you decide the time is appropriate!

@mkarolin mkarolin added this to the 1.39.x - Nightly milestone Apr 2, 2022
@mkarolin mkarolin merged commit 67f02cf into brave:master Apr 2, 2022
@Tonev Tonev deleted the issues16797 branch April 2, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Brave" in "Show Brave suggested sites in autocomplete suggestions" description
3 participants