Fixed sidebar bookmarks panel was empty after cr100

[simonhong]

fix brave/brave-browser#21819

Applied upstream changes

Author: dpapad [email protected]
AuthorDate: 2022-01-06 19:24:20 +0000
Commit: Chromium LUCI CQ [email protected]
CommitDate: 2022-01-06 19:24:20 +0000

SidePanel: Stop importing pre-JS modules Mojo bindings, not needed.

Bug: 1179821
Change-Id: I0a72614422db9bb398bd5eb48a9b7f1c79e33f1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3370342
Auto-Submit: Demetrios Papadopoulos [email protected]
Reviewed-by: John Lee [email protected]
Commit-Queue: John Lee [email protected]
Cr-Commit-Position: refs/heads/main@{#956201}

Resolves

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

1. Open sidebar bookmarks panel
2. Check bookmars panel page is shown properly

Also see #12707 (comment) for additional cases/checks.

[emerick]

LGTM

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[simonhong]

Got BraveNavigatorUserAgentFarblingBrowserTest.AddBraveToNavigatorUserAgentBrandList failure from browser test on Windows builder only.
But merged because we can see this failure from other PRs and definitely this failure is not related with this PR's change.

[kjozwiak]

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.38.66 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | Windows 11 Version 21H2 (Build 22000.556)

Reproduced the original issue using the STR/Cases outlined via brave/brave-browser#21819 (comment) using 1.38.63 Chromium: 100.0.4896.46. Went through the following verification's:

• ensured that clicking on Bookmarks via the sidebar correctly displays the users bookmarks
• ensured clicking/loading bookmarks within the sidebar works as expected
• ensured that you can move around bookmarks & folders within the sidebar
• ensured that you can view bookmarks within folders (also ensured that you can open/move these bookmarks)
• ensured that adding bookmarks into the sidebar via the + (Add) button works as expected

1.38.63 Chromium: 100.0.4896.46 (Broken)	1.38.66 Chromium: 100.0.4896.46 (Fixed)