Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve rewards icon issue #12182

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Resolve rewards icon issue #12182

merged 2 commits into from
Feb 11, 2022

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#20633
Resolves brave/brave-browser#20646

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 8, 2022
@deeppandya deeppandya added this to the 1.37.x - Nightly milestone Feb 8, 2022
@deeppandya deeppandya self-assigned this Feb 8, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

kjozwiak commented Feb 18, 2022

Verification PASSED on Pixel 6 running Android 12 using 1.37.57 Chromium: 98.0.4758.102

Test Case 1 - brave/brave-browser#20633

  • ensured that you can hide/display the rewards icon when rewards/ads hasn't been enabled yet
  • ensured that you can hide/display the rewards icon when rewards is being used/enabled
  • ensured that user state/data isn't being lost when disabling the icon and rewards has been enabled

Test Case 2 - brave/brave-browser#20633

Rewards Enabled/Rewards Icon Visible - PASSED

Rewards Enabled/Rewards Icon Hidden - FAILED

Ran into rewards icon made visible after upgrading after user has disabled it via Appearance settings #21183 - brave/brave-browser#21183. Rewards icon keeps re-appearing and not staying disabled.

Rewards Disabled/Rewards Icon Visible - PASSED

Rewards Disabled/Rewards Icon Hidden- FAILED

Ran into rewards icon made visible after upgrading after user has disabled it via Appearance settings #21183 - brave/brave-browser#21183. Rewards icon keeps re-appearing and not staying disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewards button is not shown upon upgrade Nightly on Android does not turn off Rewards icon
3 participants