Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve DNSLink as <gateway>/ipns/<dnslink-domain> #12088

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 1, 2022

Resolves brave/brave-browser#20567
Resolves brave/brave-browser#20320

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Set up a local IPFS node from brave://settings/ipfs
  2. Enable automatically redirect DNSLink to IPFS from the same page
  3. Open a tab and visit https://ipfs.io, wait for it to redirect to IPFS and note the resulting address.
  4. Open a tab and visit https://docs.ipfs.io, wait for it to redirect to IPFS and note the resulting address.

@spylogsster spylogsster requested a review from bbondy February 1, 2022 11:51
@spylogsster spylogsster self-assigned this Feb 1, 2022
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spylogsster spylogsster merged commit 27b58c7 into master Feb 3, 2022
@spylogsster spylogsster deleted the issue-20567 branch February 3, 2022 06:51
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants