Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable desktop sharing hub on stable channel #12041

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jan 28, 2022

Resolves brave/brave-browser#20757

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong self-assigned this Jan 28, 2022
@simonhong simonhong requested a review from petemill January 28, 2022 03:29
@simonhong simonhong force-pushed the desktop_sharing_hub branch from 817b443 to 700a345 Compare January 28, 2022 03:35
@simonhong simonhong requested a review from mkarolin January 28, 2022 20:08
@@ -229,6 +231,14 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
registry);
#endif

#if !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we'd care to have OS_CHROMEOS here.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mkarolin mkarolin merged commit b0e52b5 into master Jan 28, 2022
@mkarolin mkarolin deleted the desktop_sharing_hub branch January 28, 2022 22:38
@mkarolin mkarolin added this to the 1.37.x - Nightly milestone Jan 28, 2022
brave-builds pushed a commit that referenced this pull request Jan 28, 2022
brave-builds pushed a commit that referenced this pull request Jan 28, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.37.10 Chromium: 98.0.4758.74 (Official Build) nightly (64-bit)
-- | --
Revision | d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS | Windows 11 Version 21H2 (Build 22000.438)
  • visited https://github.com and ensured that the Share this page icon was still visible/functional
  • visited https://videocardz.com ensured that the Share this page icon was still visible/functional
  • ensured that Copy Link, QR Code & Save page as... is working as expected
  • ensured that the social media buttons are working as expected

Unfortunately I can't check to ensure that the share button is disabled on 1.35.x & and enabled on 1.36.x until #12055 & #12056 are uplifted we get new builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set kDesktopSharingHubEnabled to false
3 participants