-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable desktop sharing hub on stable channel #12041
Conversation
817b443
to
700a345
Compare
@@ -229,6 +231,14 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) { | |||
registry); | |||
#endif | |||
|
|||
#if !defined(OS_ANDROID) && !defined(OS_CHROMEOS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we'd care to have OS_CHROMEOS here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Verification PASSED on
Unfortunately I can't check to ensure that the share button is disabled on |
Resolves brave/brave-browser#20757
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: