Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rust as a dep and automate building of Challenge Bypass Ristretto #1199

Merged
merged 6 commits into from
Jan 10, 2019
Merged

Add Rust as a dep and automate building of Challenge Bypass Ristretto #1199

merged 6 commits into from
Jan 10, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 3, 2019 •
edited
Loading

fix brave/brave-browser#2796
requires brave-intl/challenge-bypass-ristretto-ffi#23

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@tmancey tmancey self-assigned this Jan 3, 2019
@tmancey tmancey requested a review from bridiver January 3, 2019 01:02
@tmancey tmancey changed the title Challenge bypass ristretto [WIP] Automate building of Challenge Bypass Ristretto Jan 3, 2019
@tmancey tmancey force-pushed the challenge-bypass-ristretto branch 4 times, most recently from 2f67a22 to 7af04ed Compare January 3, 2019 03:30
bridiver
bridiver reviewed Jan 3, 2019
View reviewed changes
script/cargo.py Outdated Show resolved Hide resolved
bridiver
bridiver reviewed Jan 3, 2019
View reviewed changes
script/cargo.py Outdated Show resolved Hide resolved
bridiver
bridiver reviewed Jan 3, 2019
View reviewed changes
script/cargo.py Outdated Show resolved Hide resolved
@tmancey tmancey force-pushed the challenge-bypass-ristretto branch 13 times, most recently from cea1577 to 0dd5853 Compare January 4, 2019 11:01
bridiver
bridiver reviewed Jan 9, 2019
View reviewed changes
build/cargo.gni Outdated Show resolved Hide resolved
@tmancey tmancey force-pushed the challenge-bypass-ristretto branch 4 times, most recently from 10d8bcc to ce6a503 Compare January 9, 2019 21:25
bridiver
bridiver previously approved these changes Jan 9, 2019
View reviewed changes
bridiver
bridiver previously approved these changes Jan 10, 2019
View reviewed changes
bbondy
bbondy previously approved these changes Jan 10, 2019
View reviewed changes
@tmancey tmancey dismissed stale reviews from bbondy and bridiver via 27b5201 January 10, 2019 09:33
@tmancey
Copy link
Collaborator Author

tmancey commented Jan 10, 2019

@NejcZdovc This PR was approved by @bbondy and @bridiver, I had to just update the DEP for challenge-bypass-ristretto-ffi after it was merged, so as discussed can you please approve so I am unblocked, thanks

NejcZdovc
NejcZdovc approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just re-approving based on previous approvals

@tmancey tmancey merged commit e63fb7f into master Jan 10, 2019
@tmancey tmancey deleted the challenge-bypass-ristretto branch January 10, 2019 10:13
This was referenced Jan 10, 2019
Closed
Merged
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@bridiver bridiver bridiver left review comments

@bbondy bbondy bbondy left review comments

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
0.61.x - Release
Development

Successfully merging this pull request may close these issues.

Add Rust as a dep and automate building of Challenge Bypass Ristretto
4 participants
@tmancey @bridiver @bbondy @NejcZdovc