-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust as a dep and automate building of Challenge Bypass Ristretto #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
changed the title
Challenge bypass ristretto
[WIP] Automate building of Challenge Bypass Ristretto
Jan 3, 2019
tmancey
force-pushed
the
challenge-bypass-ristretto
branch
from
January 3, 2019 01:12
cd0fdc1
to
6cbcbf8
Compare
bridiver
reviewed
Jan 3, 2019
bridiver
reviewed
Jan 3, 2019
tmancey
force-pushed
the
challenge-bypass-ristretto
branch
4 times, most recently
from
January 3, 2019 03:30
2f67a22
to
7af04ed
Compare
bridiver
reviewed
Jan 3, 2019
bridiver
reviewed
Jan 3, 2019
bridiver
reviewed
Jan 3, 2019
bridiver
reviewed
Jan 3, 2019
tmancey
force-pushed
the
challenge-bypass-ristretto
branch
13 times, most recently
from
January 4, 2019 11:01
cea1577
to
0dd5853
Compare
bridiver
reviewed
Jan 9, 2019
bridiver
reviewed
Jan 9, 2019
tmancey
force-pushed
the
challenge-bypass-ristretto
branch
4 times, most recently
from
January 9, 2019 21:25
10d8bcc
to
ce6a503
Compare
tmancey
force-pushed
the
challenge-bypass-ristretto
branch
from
January 9, 2019 21:36
ce6a503
to
8c469f4
Compare
bridiver
previously approved these changes
Jan 9, 2019
tmancey
force-pushed
the
challenge-bypass-ristretto
branch
from
January 9, 2019 22:19
8c52d58
to
2983661
Compare
bridiver
previously approved these changes
Jan 10, 2019
bbondy
previously approved these changes
Jan 10, 2019
tmancey
force-pushed
the
challenge-bypass-ristretto
branch
from
January 10, 2019 09:33
2983661
to
27b5201
Compare
@NejcZdovc This PR was approved by @bbondy and @bridiver, I had to just update the DEP for challenge-bypass-ristretto-ffi after it was merged, so as discussed can you please approve so I am unblocked, thanks |
NejcZdovc
approved these changes
Jan 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just re-approving based on previous approvals
This was referenced Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#2796
requires brave-intl/challenge-bypass-ristretto-ffi#23
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: