Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): disable EIP-1559 on Polygon and Avalanche #11968

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

onyb
Copy link
Member

@onyb onyb commented Jan 24, 2022

Our current EIP-1559 gas oracle queries the Etherscan API, which only
supports Ethereum mainnet. As a result, priority fee estimations on
custom networks use results for Ethereum mainnet, which can either
result in transactions being stuck in the mempool forever, or in
over-payment of gas fees.

This commit will be reverted in brave/brave-browser#20469.

Resolves brave/brave-browser#20652.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Demo

Before After
Screen.Recording.2022-01-24.at.6.17.57.PM.mov
Screen.Recording.2022-01-24.at.6.15.15.PM.mov

@onyb onyb requested review from bbondy, yrliou and a team January 24, 2022 12:49
@onyb onyb self-assigned this Jan 24, 2022
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@onyb onyb force-pushed the f/wallet/eip-1559-polygon-avax branch from d0e6bac to 328346f Compare January 25, 2022 08:57
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Our current EIP-1559 gas oracle queries the Etherscan API, which only
supports Ethereum mainnet. As a result, priority fee estimations on
custom networks use results for Ethereum mainnet, which can either
result in transactions being stuck in the mempool forever, or in
over-payment of gas fees.

This commit will be reverted in brave/brave-browser#20469.
@onyb onyb force-pushed the f/wallet/eip-1559-polygon-avax branch from 328346f to c0956da Compare January 25, 2022 17:30
@onyb onyb merged commit c1a60c6 into master Jan 25, 2022
@onyb onyb deleted the f/wallet/eip-1559-polygon-avax branch January 25, 2022 20:14
@onyb onyb added this to the 1.36.x - Nightly milestone Jan 25, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.36.73 Chromium: 98.0.4758.66 (Official Build) nightly (arm64)
Revision db1b4001d5ce29f141297f260d2b778e000b85a3-refs/branch-heads/4758@{#762}
OS macOS Version 12.1 (Build 21C52)
  • Verified EIP-1559 gas pricing is removed for Polygon
11968.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporarily disable EIP-1559 on Polygon and Avalanche
4 participants