Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature flags for choosing skus environment #11894

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jan 19, 2022

When one of option is selected except default, it's value is passed
via --skus-env command line switch.

fix brave/brave-browser#20557

Screen Shot 2022-01-19 at 4 51 40 PM

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch Brave with fresh profile and check --skus-env cmd line switch is not used at brave://versions
  2. Choose production for Experimental SKU Environment via brave://flags and relaunch
  3. Check --skus-env=production switch is set at brave://versions

When one of option is selected except default, it's value is passed
via --skus-env command line switch.

fix brave/brave-browser#20557
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly! Changes LGTM too

@bsclifton bsclifton merged commit be57e52 into master Jan 19, 2022
@bsclifton bsclifton deleted the skus_env_feature_flags branch January 19, 2022 17:27
@bsclifton bsclifton added this to the 1.36.x - Nightly milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SKUs environment should be configurable via brave://flags
2 participants