Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Accounts Page Multi Chain UI Support #11785

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

Updated the Accounts page UI to support multiple chains Ethereum, Solana and Filecoin

  1. Renamed Primary Accounts too Primary crypto accounts and added a description.
  2. Renamed Secondary Accounts to Imported accounts
  3. Primary crypto accounts section now has a Create account button
  4. Imported accounts section now has Import and Import from hardware wallet buttons
  5. Removed the tab navigation from the AddAccount modal to separate Create, Import and Hardware to be their own modal.
  6. Added an additional step to select a network Ethereum, Solana or Filecoin before Creating, Importing or Connecting a hardware wallet.

note:(Solana and Filecoin are disabled in the UI until we have support, but the demo video will give an example of the new UI.)

Resolves brave/brave-browser#20333

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2022-01-07.at.4.29.10.PM.mov

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner January 7, 2022 23:34
@Douglashdaniel Douglashdaniel self-assigned this Jan 7, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 7, 2022
@onyb
Copy link
Member

onyb commented Jan 10, 2022

We need a currency selection modal for import using hardware wallet as well. The Filecoin keyring only works with a Ledger.

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

ℹ️ We noted during a private huddle that the currency list for primary crypto accounts may not be the same for hardware wallet accounts (as is the case with Filecoin keyring). Let's tackle this in a separate PR.

@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 11, 2022
@Douglashdaniel Douglashdaniel merged commit 6727165 into master Jan 11, 2022
@Douglashdaniel Douglashdaniel deleted the multi-chain-accounts-page-ui branch January 11, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Accounts Page to Support Multi networks
2 participants