Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Brave Wallets Keyboard Accessibility #10937

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

Douglashdaniel
Copy link
Contributor

Description

Improved Brave Wallets Keyboard Accessibility
Before all the buttons in the wallet were not visibly focusable while tabbing through all the elements.
We now have a shared button called WalletButton that has focus-visible state that is now being used for all buttons in the wallet.

Resolves brave/brave-browser#19147

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2021-11-08.at.1.53.41.PM.mov

@Douglashdaniel Douglashdaniel requested review from bbondy and onyb November 8, 2021 21:04
@Douglashdaniel Douglashdaniel self-assigned this Nov 8, 2021
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Douglashdaniel Douglashdaniel merged commit fa87a4b into master Nov 9, 2021
@Douglashdaniel Douglashdaniel deleted the wallet-keyboard-accessibility branch November 9, 2021 00:10
@Douglashdaniel Douglashdaniel added this to the 1.33.x - Nightly milestone Nov 9, 2021
brave-builds pushed a commit that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Wallet Element Accessibility
3 participants