Upgrade from Chromium 96 to Chromium 97 #10664

….4676.0.

Chromium change: https://chromium.googlesource.com/chromium/src/+/9a697f9b7b1b6a51118ae420adb4ee96fa647243 commit 9a697f9b7b1b6a51118ae420adb4ee96fa647243 Author: Peter Boström <[email protected]> Date: Fri Oct 15 23:27:56 2021 +0000 Add chrome::ShowBubble() for anchored DialogModels This migrates OutdatedUpgradeBubbleView to chrome/browser/ui/dialogs/ as ShowOutdatedUpgradeBubble(). Follow-up actions should move other dialogs (such as window_name_prompt) into this directory. This also adds chrome/browser/ui/browser_element_identifiers.h to be able to refer to the app menu from outside of views code to end up anchoring to it. This also replaces BrowserAppMenuButton::kIdentifier with kAppMenuElementId for this purpose. Bug: 1259210

Chromium change: https://chromium.googlesource.com/chromium/src/+/1307bd02195bd73a52ab0651ef3d629d619deb33 commit 1307bd02195bd73a52ab0651ef3d629d619deb33 Author: Tommy Steimel <[email protected]> Date: Mon Oct 18 18:52:40 2021 +0000 GMC: Rename chrome/app/global_media_controls_strings to avoid collision With the addition of the new global media controls component, we now have two different grdp files named global_media_controls_strings: components/global_media_controls_strings.grdp and chrome/app/global_media_controls_strings.grdp This CL renames the chrome/app one to gmc_strings.grdp Bug: 1260955

Chromium change: https://chromium.googlesource.com/chromium/src/+/e140256d3df3b1cb6c8d2c2d82775f67bc75d172 commit e140256d3df3b1cb6c8d2c2d82775f67bc75d172 Author: Miras Myrzakerey <[email protected]> Date: Tue Oct 12 06:49:54 2021 +0000 Merge WebBundleBuilder between data_decoder:: and web_package::test:: This CL merges the functionality of a WebBundleBuilder that's used by a WebBundler in services/data_decoder and WebBundleBuilder that's used for testing in components/web_package/test_support. The resulting WebBundleBuilder resides in components/web_package and used everywhere. Bug: 1193871

Chromium changes: https://source.chromium.org/chromium/chromium/src/+/e5a38eddbdf45d7563a00d019debd11b803af1bb commit e5a38eddbdf45d7563a00d019debd11b803af1bb Author: Peter Kasting <[email protected]> Date: Sat Oct 2 03:06:35 2021 +0000 Migrate "base::TimeDelta::FromX" to "base:X". All changes were done automatically with git grep, sed, xargs, etc. Bug: 1243777 https://source.chromium.org/chromium/chromium/src/+/7b54ffec9bcbc6658b7238f79a540e37cbaf352a commit 7b54ffec9bcbc6658b7238f79a540e37cbaf352a Author: Peter Kasting <[email protected]> Date: Wed Oct 13 11:25:42 2021 +0000 Remove deprecated TimeDelta functions. Bug: 1243777

Chromium change: https://chromium.googlesource.com/chromium/src/+/39810e70da06baca176c0cdbc93164be1f980f59 commit 39810e70da06baca176c0cdbc93164be1f980f59 Author: Patrick Monette <[email protected]> Date: Thu Oct 14 18:06:59 2021 +0000 Reland "Move task-related files from base/ to base/task/" This is a reland of 092c30c5fd4def5a0c63d6f3a8953bd07768dd44 The 2 problematic subrepos have been migrated and a couple late addition of the old headers were migrated. Original change's description: > Move task-related files from base/ to base/task/ > > The forward headers are updated to point to the new location, and the > header guards were fixed. > > Bug: 1255932

Chromium change: https://chromium.googlesource.com/chromium/src/+/8fdc224330e046268b83d7c9ff98fcb292c3db72 commit 8fdc224330e046268b83d7c9ff98fcb292c3db72 Author: cfredric <[email protected]> Date: Thu Oct 14 03:24:00 2021 +0000 Rename MRUCache to LRUCache. https://en.wikipedia.org/wiki/Cache_replacement_policies indicates that this implementation is actually an LRU cache, not an MRU cache. An MRU cache evicts the most-recently-used item first. This CL also renames some variables and an enum for consistency, since it would be weird for an `mru_cache_` member to actually be an LRU cache.

Chromium change: https://source.chromium.org/chromium/chromium/src/+/800532c0bf6712ea4ab5928da9e776d6607a10b1 commit 800532c0bf6712ea4ab5928da9e776d6607a10b1 Author: Mike West <[email protected]> Date: Thu Oct 14 09:26:52 2021 +0000 Deprecate returning a GURL from GURL::GetOrigin(). This patch renames `GURL::GetOrigin()` to `GURL::DeprecatedGetOriginAsURL()`. A subsequent patch will reintroduce a `GURL::GetOrigin()` that returns a `url::Origin` rather than a `GURL`. This patch was brought to you by sed, followed by a little manual work to deal with look-alike methods (most notably `CascadePriority::GetOrigin()` and `NudgeTracker::GetOrigin()`) and two or three spots that held pointers to GURLs: ``` git grep -n -l ".GetOrigin(" | \ xargs -L1 sed -i '' \ -e 's/\.GetOrigin(/.DeprecatedGetOriginAsURL(/g' ``` Bug: 512374

Chromium change: https://chromium.googlesource.com/chromium/src/+/eb6a38f commit eb6a38f6fa54962e1115e1776609680a087aa6f2 Author: Alex Gough <[email protected]> Date: Fri Oct 22 01:55:13 2021 +0000 Replace sandbox::policy::SandboxType with mojom Sandbox enum sandbox.mojom.Sandbox can now be used as the sandbox type so we replace it everywhere. The guts of the change are in //sandbox/policy/sandbox_type.h where SandboxType is now deleted, and //sandbox/policy/mojom/sandbox.mojom where sandbox types that are not already used in mojom ServiceSandbox attributes are added. Some cascading changes:- - kService wasn't implemented on Mac (as it is equivalent to kUtility). As we cannot alias enum fields in mojo like we can in C++ I have added kService for Mac. The alternative is to define platform specific ServiceSandbox attributes for all kService interfaces which seems to put this complexity in the wrong place. - sandbox_type.h included a number of buildflag headers that other files then relied on. As sandbox_type.h is no longer needed in many places and no longer needs these defines, they have been introduced where required. - sandbox::mojom::Sandbox is forward declared in a couple of headers that are widely imported, hopefully reducing the number of times the mojom.h is included but not used. - some build deps must be modified. - LibAssistantService needs a sandbox to be defined even when hosted in process, so has kNoSandbox now when enable_cros_libassistant is false. Bug: 1210301

The sandbox type is inferred by content::ServiceProcessHost::Launch from the mojom interface of the receiver passed into it. Chromium change: https://source.chromium.org/chromium/chromium/src/+/ec569389922f7fc66486dcd94a5b4b5ccd0a15a9 commit ec569389922f7fc66486dcd94a5b4b5ccd0a15a9 Author: Alex Gough <[email protected]> Date: Tue Oct 12 00:55:44 2021 +0000 Specify Audio and Network sandboxes in mojo Adds ServiceSandbox attribute to AudioService and NetworkService interfaces and deletes the final service_sandbox_type.h file. All service sandboxes are now specified this way. These two services are different, however. Their sandboxes can be disabled (to kNoSandbox) by policy or feature flags. This means the service launching machinery must know how to do this. In this CL we move this logic into the ServiceProcessHost which in turn asks the ContentBrowserClient if the sandboxes should be enabled. As this is only necessary for two sandbox types we have not generalised the CBC interface. We also delete `sandbox_type` from service process host options as it cannot be specified as an option and must be specified using the ServiceSandbox attribute on the launched mojom. We migrate the type used within ServiceProcessHost to sandbox::mojom::Sandbox. A future CL will replace sandbox::policy::mojom::SandboxType with disabled (to kNoSandbox) by policy or feature flags. This means the service launching machinery must know how to do this. In this CL we move this logic into the ServiceProcessHost which in turn asks the ContentBrowserClient if the sandboxes should be enabled. As this is only necessary for two sandbox types we have not generalised the CBC interface. We also delete `sandbox_type` from service process host options as it cannot be specified as an option and must be specified using the ServiceSandbox attribute on the launched mojom. We migrate the type used within ServiceProcessHost to sandbox::mojom::Sandbox. A future CL will replace sandbox::policy::mojom::SandboxType with the mojom type throughout. Bug: 1210301

In file included from ../../brave/third_party/bitcoin-core/src/src/secp256k1/src/secp256k1.c:19: ../../brave/third_party/bitcoin-core/src/src/secp256k1/src/ecdsa_impl.h(312,12): error: use of bitwise '&' with boolean operands [-Werror,-Wbitwise-instead-of-logical] return !secp256k1_scalar_is_zero(sigr) & !secp256k1_scalar_is_zero(sigs); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ && ../../brave/third_party/bitcoin-core/src/src/secp256k1/src/ecdsa_impl.h(312,12): note: cast one or both operands to int to silence this warning 1 error generated.

Chromium change: https://source.chromium.org/chromium/chromium/src/+/ab5b5e73eb0d0c321300360585187dd3c5e45b24 commit ab5b5e73eb0d0c321300360585187dd3c5e45b24 Author: Dave Vandyke <[email protected]> Date: Mon Oct 18 19:47:59 2021 +0000 Avoid displaying allowed localStorage usage if currently empty The PageInfo bubble displays a count of how many cookies are in use by the current website. That count includes not only cookies but also similar storage such as localStorage and IndexedDB. The "Cookies in use" dialog provides a further breakdown of the page's allowed and blocked storage usage. With this change, we take care to only include localStorage in the cookie count and allowed cookies breakdown if localStorage isn't empty for the page. Note: - We still consider localStorage to have been blocked, even if it is empty. - We still don't consider non-empty localStorage to have been allowed until OnDomStorageAccessed has fired for it. - These changes only apply to localStorage, not other types of storage such as IndexedDB. Bug: 1152401

Feature switch has been removed. Chromium change: https://chromium.googlesource.com/chromium/src/+/1746a920a7ddafcff0f8ea5ddb6d75e54cb7a21a commit 1746a920a7ddafcff0f8ea5ddb6d75e54cb7a21a Author: David Benjamin <[email protected]> Date: Thu Oct 14 17:16:57 2021 +0000 Unwind kLegacyTLSEnforced feature flag The feature shipped, so we no longer need the flag. This doesn't change behavior, just unwinds the old feature flag to toggle the existing interstitial. Bug: 1044750

We are redefining MigrateObsoleteProfilePrefs, but a new call was added to browser_prefs.cc that uses the same method name: translate::TranslatePrefs::MigrateObsoleteProfilePrefs Added overrides to translate_prefs.h/cc to rename the method the same way it gets renamed in browser_prefs.cc Chromium change: https://source.chromium.org/chromium/chromium/src/+/0c61cb910bb9da119599b9c680655bc16403e88c commit 0c61cb910bb9da119599b9c680655bc16403e88c Author: mlcui <[email protected]> Date: Wed Oct 20 01:56:11 2021 +0000 inclusive: Migrate always translate pref to "translate_allowlists" This pref name was already used in TranslatePrefs::MapPreferenceName, and this CL follows chrome/browser/prefs/README.md to migrate the pref over to use "translate_allowlists" in the pref store. As a result, this removes the usage of less-inclusive language in a few JavaScript files. Fixes: chromium:1233176

Chromium change: https://source.chromium.org/chromium/chromium/src/+/ccf421690e5a665cc6d8d6290ac841b21dbd6ca3 commit ccf421690e5a665cc6d8d6290ac841b21dbd6ca3 Author: Marc Treib <[email protected]> Date: Tue Oct 19 14:27:33 2021 +0000 Sync: Replace outdated "authenticated / primary account" terminology This CL rename SyncService::IsAuthenticatedAccountPrimary() with HasSyncConsent(), and GetAuthenticatedAccountInfo() with just GetAccountInfo(). "Authenticated account" is some outdated terminology that's not used in sign-in code anymore. More importantly, "primary account" was used here in an outdated meaning that wasn't consistent anymore with how it's used in signin code. This is a pure rename; no behavior changes. Bug: 1254280

Chromium change: https://chromium.googlesource.com/chromium/src/+/b0690d7d072abb commit b0690d7d072abb347dee0b656e49d29602f0a8f3 Author: chromium-autoroll <[email protected]> Date: Wed Oct 13 20:20:47 2021 +0000 Roll GoogleTest from 075810f7a204 to 16f637fbf4ff (4 revisions) https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/075810f7a204..16f63 fbf4ff 2021-10-13 [email protected] Googletest export 2021-10-13 [email protected] Googletest export 2021-10-13 [email protected] Merge pull request #3602 from yesudeep:try-fix-linker-errors-on-freebsd 2021-10-13 [email protected] Googletest export

RouteObserverBehavior is now a ChromiumOS-specific utility which has moved from router.js into route_observer_behavior.js, so we need to migrate into using RouteObserverMixin instead. Chromium change: https://chromium.googlesource.com/chromium/src/+/775f9f5d2ca32cf0ab5545045301f8c5b9e6b310 commit 775f9f5d2ca32cf0ab5545045301f8c5b9e6b310 Author: dpapad <[email protected]> Date: Mon Oct 11 08:40:24 2021 +0000 Settings: Move RouteObserverBehavior to OS Settings, only used there. Browser Settings no longer uses RouteObserverBehavior, as it has been migrated to RouteObserverMixin. Moving it to OS Settings is a preparatory step for migrating the shared router.js file to TypeScript. Bug: 1234307

Chromium change: chromium/chromium@902c97b feed modularization: move ntp.snippets to feed.sections Also: * removed the obsolete '!mHasHeader' logic in start surface. * Moved creation of section header view into FeedSurfaceCoordinator. Bug: 1254437

Chromium change: chromium/chromium@16c4128 [GMNext] Make default_icon_color_blue usages dynamic This CL replaces the blue icon colors with colorPrimary. Bug: 1251798

…4681.0.

Chromium changes: https://chromium.googlesource.com/chromium/src/+/5ba07f7e15d9c0fce4c3e7f3a0d81b7e2d0e1ac1 https://chromium.googlesource.com/chromium/src/+/36a1fd69363120111a078f9b0e3d5458b9a6f461 https://chromium.googlesource.com/chromium/src/+/0049a0b7166118b686e736fd4a672ce0bb02e182 commit 5ba07f7e15d9c0fce4c3e7f3a0d81b7e2d0e1ac1 Author: Matt Reichhoff <[email protected]> Date: Thu Oct 21 20:36:32 2021 +0000 Remove TestNetLog and its subclasses This builds on the prior deletion of use of these classes. RecordingNetLogObserver remains in place and is used instead of the prior classes. Future cleanup will target NetLog pointers. Bug: 1052479 commit 36a1fd69363120111a078f9b0e3d5458b9a6f461 Author: Matt Reichhoff <[email protected]> Date: Tue Oct 12 22:52:20 2021 +0000 Remove direct use of RecordingTestNetLog This is the first of several commits to address test_net_log cleanup. Future commits will target RecordingBoundTestNetLog, full deletion of the classes, and removal of many NetLog pointers. Bug: 1052479 commit 0049a0b7166118b686e736fd4a672ce0bb02e182 Author: Matt Reichhoff <[email protected]> Date: Wed Oct 20 20:44:26 2021 +0000 Remove direct use of RecordingBoundTestNetLog This builds on the prior deletion of use of TestNetLog and RecordingTestNetLog. A future commit will delete the classes. Bug: 1052479

Looks like it was unintentionally introduced in commit 1e8418b [1]. [1] 1e8418b0a3

Chromium change: https://chromium.googlesource.com/chromium/src/+/127bce846e0dfc3217bc8ec0c0ec886bfe563f71 commit 127bce846e0dfc3217bc8ec0c0ec886bfe563f71 Author: Marc Treib <[email protected]> Date: Wed Oct 20 13:03:23 2021 +0000 Replace outdated 'is_primary' terminology in SyncAccountInfo Before this CL, SyncAccountInfo contained an 'is_primary' flag. This did *not* correspond to IdentityManager's concept of "primary account" and was thus confusing. This CL renames the field to 'is_sync_consented' which matches IdentityManager's terminology. Bug: 1254280

This method was added in commit 88fbb5c [1] as a way to initialize the WebUIBubbleManagerT<WalletPanelUI> using the current anchor view, but that initialization was removed later on in commit 3cd2a7f [2], leaving the method just assigning a local |anchor_view| variable that never gets used now. This is now leading to a -Werror,-Wunused-but-set-variable error when compiling, so this patch removes the method and all its callpoints. [1] 88fbb5cc23 [2] 3cd2a7f076

Old used as as stub INLINE_UPDATE_READY_INFOBAR_ANDROID was removed by Chromium's change Chromium change: chromium/chromium@b0f8692 [Android] Remove support for inline updates Bug: 1201691 Change-Id: I966b9bf106e3190b0d86f56181011bb9f0521218

This feature is now being enabled by default for Linux, Windows and Mac, which is interfering with Brave's own internal tranlate engine, so we now need to explicitly disable it. Chromium change: https://chromium.googlesource.com/chromium/src/+/15e59cc7caed2b3e0401bcc6b8b4fa3fa94a07f9 commit 15e59cc7caed2b3e0401bcc6b8b4fa3fa94a07f9 Author: mcrouse <[email protected]> Date: Wed Oct 20 17:38:30 2021 +0000 [LangID] Enable TFLite Language Detection by default on Desktop. This enables language detection by default on desktop. Note: This also changes how tests for translate browsertests works in cases that relying on content/language detection is not necessary. This makes the test more reliable and less bulky. We likely want to improve this over time but this gets us to a point we can enable the model on ToT. This is fully behind Finch control and we will keep it that way for safety for a few milestones. Bug: 1159144

This test was not being properly setup since a string was expected to be set as the value for ad_serving_parameters["ad_serving_version"], but instead an integer (2, instead of "2") was being passed. And we didn't noticed until now because the parsing problem would go unnoticed as a DLOG(WARNING), resulting in the default value being used, but now that the DLOG(WARNING) became a NOTREACHED() the test is crashing instead. To fix this, we just make sure we actually set a string as the value for ad_serving_parameters["ad_serving_version"], and also add a couple of checks more in the test suite to make sure that AdServing is enabled and that the version being used is, indeed, version 2. Chromium change: https://chromium.googlesource.com/chromium/src/+/bf076ce0d82267340f9ba6aa4849d8a37aa8a0db commit bf076ce0d82267340f9ba6aa4849d8a37aa8a0db Author: Christian Dullweber <[email protected]> Date: Wed Oct 20 10:35:26 2021 +0000 AccuracyTips: Fix field_trial config and add DCHECKs to config parser FeatureParam<TimeDelta> does not support days as parameter value, so our "1d" config is not parsed correctly and instead 7 days are used. Fix the config by using hours and throw errors when an incorrect config is parsed instead of just logging a warning to avoid future issues. Bug: 1261162

This method will go away soon, so we get rid of Brave-specific instances now to prepare for the future. For now, this patch just makes sure we don't call the deprecated method, but ideally we should probably make deeper changes not to use a GURL as the type for origins, and use url::Origin instead. Chromium change: https://chromium.googlesource.com/chromium/src/+/e439902e17bbd1f540f7dc7f6e3e153871c76b34 commit e439902e17bbd1f540f7dc7f6e3e153871c76b34 Author: Matt Menke <[email protected]> Date: Thu Oct 21 18:04:42 2021 +0000 Reporting: Remove use of GURL::DeprecatedGetOriginAsURL(). In some places this was called only to eventually convert the result to an Origin. Also make reporting APIs that were taking a URL only to convert it to an origin take origins instead. Bug: 512374

Chromium change: chromium/chromium@840e508 [Read Later] Add menu items for bookmarks and reading list Bug: 1257406, 1252228

Chromium change: chromium/chromium@9569e3d [Android][FRE] Record number of accounts for all users started FRE This CL moves the recording of the number of accounts for all users who started FRE from SyncConsentFirstRunFragment to FirstRunFlowSequencer as this metric is not tied to sync consent page. Bug: 1259535

Chromium change: https://source.chromium.org/chromium/chromium/src/+/372dd5631b101af55b8b6df7f504c7488ba4b6f7 commit 372dd5631b101af55b8b6df7f504c7488ba4b6f7 Author: Caitlin Fischer <[email protected]> Date: Mon Oct 18 20:19:31 2021 +0000 Replace Setup with SetUp in a couple functions. * SetUpFieldTrials * SetUpFeatureControllingFieldTrials The letter U should be capitalized since 'set up' is two words in this context.

…4688.2.

We can't keep using set_use_custom_frame since this is now appearing twice in the file due to the newly-added macro, so change to using ResetViewShownTimeStampForTesting instead as the "anchor". Chromium change: chromium/chromium@88e9a2c commit 88e9a2cbedc02b74fa44e6593876ff66604c9688 Author: Allen Bauer <[email protected]> Date: Wed Oct 27 15:34:56 2021 +0000 Convert WebAppConfirmationView to use views::Builder and TableLayout instead of GridLayout. Bug: 1261301

policy_extension_reinstaller.h does no longer exist and corrupted_extension_reinstaller.h should be included now. Chromium change: chromium/chromium@f76028a commit f76028aba3bdcaed6b561c29954a53f67fa96538 Author: Oleg Davydov <[email protected]> Date: Fri Oct 29 18:58:31 2021 +0000 [Extensions] Rename PolicyExtensionReinstaller Rename PolicyExtensionReinstaller to the CorruptedExtensionReinstaller, since from some time ago (https://crrev.com/c/2792265) it handles user-installed extensions as well. Bug: 1263544

Constructors and Create methods no longer expect a raw pointer. Chromium change: chromium/chromium@49e30ea commit 49e30ea02860a4b573e2c7309429c0a5b3a740e2 Author: Lukasz Anforowicz <[email protected]> Date: Thu Oct 28 20:31:56 2021 +0000 [reland] Use correct source_site_instance if navigating via context menu Before this CL there would be a discrepancy - navigation via the context menu could be associated both 1) with the subframe where the right click happened and 2) with the focused frame. In particular, RenderViewContextMenuBase::OpenURLWithExtraHeaders would set `open_url_params.initiator_origin` based on the subframe, while setting `open_url_params.source_site_instance` based on the focused frame obtained by ChromeWebContentsViewDelegateViews::BuildMenu via a call to `web_contents->GetFocusedFrame()`. Typically both frames (context menu frame and the focused frame) would be the same, but in some scenarios the main frame could retain the focus even while a subframe is opening a context menu. This CL modifies ChromeWebContentsViewDelegateViews::ShowContextMenu and ChromeWebContentsViewDelegateMac::ShowContextMenu so that they forward the original subframe to the BuildMenu method (rather than replacing it with the WebContents). Most of the other changes in the CL are just a cascading consequence of changing the parameter type of BuildMenu. This way the context menu is associated with a single frame (removing the focused frame from the considerations). Bug: 1257907

This no longer expects a Profile*, but two callbacks instead. Adapt our chromium_src following the lead of upstream's first_run_dialog.cc. Chromium change: chromium/chromium@5383571 commit 5383571ed545cf9bdb034c72e76844b2aab53dc3 Author: Peter Kasting <[email protected]> Date: Wed Oct 27 00:31:11 2021 +0000 Remove GridLayout from first_run_dialog.cc. Also adds a simple UI test to show the dialog. Bug: 1261301

This feature has launched by default upstream but we still need to disable it as per request from the Security team, so we basically bring back the previous behaviour via a chromium_src override, plus a small patch to adapt javascript_frameworks_ukm_observer.cc. Chromium change: chromium/chromium@34af795 commit 34af795689999a2670d0238dedb5892b35e1642b Author: Nicolás Peña Moreno <[email protected]> Date: Wed Oct 27 21:22:47 2021 +0000 Remove flag for framework detection The feature is enabled by default, and the flag is no longer needed. Bug: 1006274

This change upstream was motivated by the work on MPArch, meaning that we need to rely on the ForEachRenderFrameHost() methods now, as well adapt tests where needed. Chromium change: chromium/chromium@4e3a623 commit 4e3a62323f0487be3ea815396281bc306c0445f6 Author: Dave Tapuska <[email protected]> Date: Wed Oct 27 16:14:02 2021 +0000 Rewrite Extension url checking to use ForEachRenderFrameHost. Replace last usage of GetAllFrames with ForEachRenderFrameHost. The debugger API checks that each frame has may attach to the URL, change this to iterate all frames from the primary main frame. Remove deprecated API from WebContents. BUG=1208438

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/db3c4f57c5624d6ec1b644036527644dfca8710e commit db3c4f57c5624d6ec1b644036527644dfca8710e Author: Jesse McKenna <[email protected]> Date: Thu Oct 28 00:53:21 2021 +0000 breadcrumbs: rename application breadcrumbs logger This change renames ApplicationBreadcrumbsLoggerIOS to just ApplicationBreadcrumbsLogger, removing the IOS suffix. This is more concise, and matches the naming style of other platform-specific classes in the same folder, e.g., BreadcrumbManagerTabHelper. The directory path is sufficient to inform the reader that this is the iOS implementation of the class. Bug: 1163762

Chromium change: chromium/chromium@e2b1868 feed modularization: Move more classes to module Move more Feed classes over to the Feed module. Bug: 1254437

…4692.8.

The TabStrip::ShouldHideCloseButtonForTab() method has been removed upstream. To preserve the behavior to show close button on inactive tabs only on hover added an additional chromium_src override to tab.cc Chromium change: https://chromium.googlesource.com/chromium/src.git/+/bc1aac74a88ad9ce554f048b6404b9e72383c832 commit bc1aac74a88ad9ce554f048b6404b9e72383c832 Author: Taylor Bergquist <[email protected]> Date: Thu Nov 4 21:40:49 2021 +0000 Remove stacked tabs from the rest of TabStrip. Bug: 1250061

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/f28af265fea678a12de47233836c2d08fab3641c commit f28af265fea678a12de47233836c2d08fab3641c Author: Nicolas Dossou-Gbete <[email protected]> Date: Thu Nov 4 13:36:41 2021 +0000 Make component updater registration stop depending on a profile The only dependency was due to cleanup code for the flash plugin's local artifacts. That cleanup has been shipped for more than a year (see https://crbug.com/1069814), so can now be removed. With that done, we can simplify the registration to make it more explicit that the component updater registration does need a profile anymore. Bug: 1069814, 1150326

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/a97d6c673eb5b1d3a890c4eacd8410283994b022 commit a97d6c673eb5b1d3a890c4eacd8410283994b022 Author: Illia Klimov <[email protected]> Date: Thu Nov 4 20:47:43 2021 +0000 Reland "Reland "Increase chip's tracking granularity."" This reverts commit d083a26e72a92f97d730de7bdeb93fe948cfca49. Reason for revert: Flaky tests will be reimplemented as Interactive tests. Original change's description: > Revert "Reland "Increase chip's tracking granularity."" > > This reverts commit fcd7314e5829a5f21ea1bfbedac09b0ef0c3c3f9. > > Reason for revert: Still causing test failures. See e.g.: > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/16549/ > > Original change's description: > > Reland "Increase chip's tracking granularity." > > > > This reverts commit 85ad368ad03349967f9db54051f472be0d395ec7. > > > > Reason for revert: Fixing test and relanding the commit. > > > > Original change's description: > > > Revert "Increase chip's tracking granularity." > > > > > > This reverts commit ca6287b7032c1b19620fadf88fe4389ae21026f1. > > > > > > Reason for revert: <Suspect causing test failures - https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/18173/overview> > > > > > > Original change's description: > > > > Increase chip's tracking granularity. > > > > > > > > This CL adds more granular tracking for users' actions with Chip. That > > > > allows differentiating what kind of a chip was shown, and what > > > > permission prompt's buttons the user clicked. > > > > > > > > Bug: 1253842 > > > > Change-Id: I0a5f0e478947980b3cd688181492008853c77af1 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202091 > > > > Reviewed-by: Ravjit Singh Uppal <[email protected]> > > > > Reviewed-by: Collin Baker <[email protected]> > > > > Commit-Queue: Illia Klimov <[email protected]> > > > > Cr-Commit-Position: refs/heads/main@{#933822} > > > > > > Bug: 1253842 > > > Change-Id: Icc39a900bdefe20da36ef827eb7dc21803123998 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3237450 > > > Auto-Submit: David Bienvenu <[email protected]> > > > Bot-Commit: Rubber Stamper <[email protected]> > > > Commit-Queue: David Bienvenu <[email protected]> > > > Reviewed-by: Samuel Huang <[email protected]> > > > Owners-Override: David Bienvenu <[email protected]> > > > Cr-Commit-Position: refs/heads/main@{#933922} > > > > Bug: 1253842 > > Change-Id: I8286eaebf5a7d9e0c1705a3b5f95a1d6bf4a1493 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3241323 > > Reviewed-by: Balazs Engedy <[email protected]> > > Reviewed-by: Ravjit Singh Uppal <[email protected]> > > Reviewed-by: Collin Baker <[email protected]> > > Commit-Queue: Illia Klimov <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#934712} > > Bug: 1253842 > Change-Id: I6b470b638b99a0aa9f0bba60b6d39e6b19e12a55 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245332 > Auto-Submit: Rune Lillesveen <[email protected]> > Owners-Override: Rune Lillesveen <[email protected]> > Commit-Queue: Rubber Stamper <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#934872} Bug: 1253842

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/61e816d489f1f574b609435922de3a48334c7b8d commit 61e816d489f1f574b609435922de3a48334c7b8d Author: Andrew Williams <[email protected]> Date: Mon Nov 1 04:41:04 2021 +0000 BroadcastChannel: Partition using StorageKey instead of Origin This CL updates the BroadcastChannel implementation so that partitioning is done by StorageKey instead of Origin. To facilitate this, it also changes the way in which Mojo messages are sent to preserve per-thread message ordering (as required by the BroadcastChannel specification). Previously, a shared, per-thread Remote was used to send messages from the renderer to RenderProcessHost on the browser side. This message would contain the origin, which the browser code would verify was accurate, and would then be used to establish the channel connection. This approach presents a challenge when switching to StorageKey, in that there's not a way to have the renderer send the StorageKey and have the browser verify it at the process level. This CL removes the origin from the message definition and replaces the RenderProcessHost handler (BroadcastChannelProvider instance) with separate ones for RenderFrameHostImpl, DedicatedWorkerHost, SharedWorkerHost, and ServiceWorkerHost instances. These new handles associate incoming connection attempts with their StorageKeys, allowing partitioning to be done without any information directly provided by the renderer. Shared per-thread Remotes are still used for workers to send messages to their corresponding host instance's BroadcastChannelProvider, and for frames a channel-associated interface is used to ensure that renderer messages are received in-order by the corresponding RenderFrameHostImpl. For more details, see the "Partitioned BroadcastChannel Design" document: https://docs.google.com/document/d/1CchMLU8QmDEx_tA0y57qLyQWvaTT3dlWF-4P_ncc06E/edit?usp=sharing Bug: 1239274

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/ea58b457dd75daeeba5911a5b32b2cef7a5ed3c9 commit ea58b457dd75daeeba5911a5b32b2cef7a5ed3c9 Author: Istiaque Ahmed <[email protected]> Date: Wed Nov 3 17:33:47 2021 +0000 [Extensions] RunFunctionAndReturnSingleResult returns owned result. This CL makes extension_function_test_utils::RunFunctionAndReturnSingleResult return std::unique_ptr instead of unowned base::Value*. This will make the "result" to never leak. Bug: 1263370

This was an upstream patch that now made it to cr97. Chromium change: https://chromium.googlesource.com/chromium/src/+/f077b2ff2c8ed4b1772f04fcdff67abd74d47c17 commit f077b2ff2c8ed4b1772f04fcdff67abd74d47c17 Author: Brian Ryner <[email protected]> Date: Thu Oct 14 21:15:11 2021 +0000 Use a newer version of numpy on mac-arm64. Older versions of numpy do not build for arm64. Sadly, the newer version does not work on very old (but supported) versions of macOS, so keep using the old version for all other platforms. Bug: 1235841

This override does no longer make sense, so we can drop it. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/c162640e5196c2e230262ce1062f262a5b61ef21 commit c162640e5196c2e230262ce1062f262a5b61ef21 Author: Daniel Rubery <[email protected]> Date: Wed Oct 13 15:02:01 2021 +0000 Remove client_side_model_loader.cc This CL removes a file missed by the previous cleanup, as well as marking a histogram from that file obsolete. Fixed: 1252857, 1258690

They need one ../ more

The `#define StandardReferralCodeLen 6` in the chromium_src override for mini_installer.h is only used from mini_installer.cc, so we can simply replace it with a constant private to that translation unit.

The following URLs were missing from the list in brave://about: * brave://adblock * brave://ipfs-internals * brave://rewards * brave://rewards-internals * brave://tor-internals * brave://wallet * brave://welcome ...because the constant used to inject that list into kChromeHostURLs is no longer there, so we need to pick a new "anchor" now. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/188f97443d21b20a33e6cad3ab8179dee24e62c8 commit 188f97443d21b20a33e6cad3ab8179dee24e62c8 Author: Adrienne Walker <[email protected]> Date: Wed Oct 27 10:20:48 2021 +0000 appcache: remove internals ui hookup This removes the chrome://appcache-internals url. The code that backs this will be removed in a followup. Bug: 582750

Chromium change: chromium/chromium@f7e3a41 Adds ability to include both v8 snapshot types And adds feature as to which one is used at runtime. Specific parts: . adds gn arg: include_both_v8_snapshots. At this time this is only supported on android. I will likely make it work on chromeos next. . Adds feature kUseContextSnapshot. This feature is available if include_both_v8_snapshots is set. . Adds switch kUseContextSnapshotSwitch. This is passed from browser to renderer if kUseContextSnapshot is enabled. A separate switch is used as at the time the v8 snapshot is loaded features have not been loaded. And this updates a bunch of build targets accordingly. BUG=1257321 TEST=none Change-Id: I225a9235ac00e1c25ceaf0423587a00a1aafc740

With new R8 library there is a warning related to our bytecode patching: Warning: Missing method void Lg2.d() (referenced from: void Vf2.run()) Without obfuscation it looks like this: Warning: Missing method void org.chromium.chrome.browser.toolbar.ToolbarManager.$invoke$special$updateButtonStatus() (referenced from: void org.chromium.chrome.browser.toolbar.ToolbarManager$$ExternalSyntheticLambda3.run()) We do change invoke special to invoke virtual for this method and this is expected. Chromium change: chromium/chromium@e3db48a Android: Stop disabling R8's allowaccessmodification -keep semantics Causes a 5.5kb regression, but brings us closer to stock R8, and will ensure visibility of test @rule fields are not changed, thus avoiding bugs like bug 1265431. Bug: 1265431

This reverts previous commit: [Android] Filter warning after bytecode pacthing With new R8 library there is a warning related to our bytecode patching: Warning: Missing method void Lg2.d() (referenced from: void Vf2.run()) Without obfuscation it looks like this: Warning: Missing method void org.chromium.chrome.browser.toolbar.ToolbarManager.$invoke$special$updateButtonStatus() (referenced from: void org.chromium.chrome.browser.toolbar.ToolbarManager$$ExternalSyntheticLambda3.run()) We do change invoke special to invoke virtual for this method and this is expected. Chromium change: chromium/chromium@e3db48a Android: Stop disabling R8's allowaccessmodification -keep semantics Causes a 5.5kb regression, but brings us closer to stock R8, and will ensure visibility of test @rule fields are not changed, thus avoiding bugs like bug 1265431. Bug: 1265431

- Added BUILD.gn files to exclusions - Added *test.mm files to exclusions - Alphabetized exclusions

Removed obsolete check

…4692.20.

The flag is no longer needed: the tests run normally on CI without it.

When building tests the following error happens: 17:40:57 gen/chrome/test/data/webui/settings/preprocessed/test_lifetime_browser_proxy.ts:11:14 - error TS2420: Class 'TestLifetimeBrowserProxy' incorrectly implements interface 'LifetimeBrowserProxy'. 17:40:57 Property 'relaunchOnMac' is missing in type 'TestLifetimeBrowserProxy' but required in type 'LifetimeBrowserProxy'. 17:40:57 17:40:57 11 export class TestLifetimeBrowserProxy extends TestBrowserProxy implements 17:40:57 ~~~~~~~~~~~~~~~~~~~~~~~~ 17:40:57 17:40:57 gen/chrome/browser/resources/settings/tsc/lifetime_browser_proxy.d.ts:4:5 17:40:57 4 relaunchOnMac(): void; 17:40:57 ~~~~~~~~~~~~~~~~~~~~~~ 17:40:57 'relaunchOnMac' is declared here. which means we'd have to add a patch to test_lifetime_proxy.ts to add our relaunchOnMac functionality. Instead, this change removes all relaunchOnMac functionality from WebUI and moves it into the BrowserLifetimeHandler.

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/fdf5d8eb7fb14333f433299f3acb0a98e979a6dd commit fdf5d8eb7fb14333f433299f3acb0a98e979a6dd Author: Olesia Marukhno <[email protected]> Date: Tue Nov 2 15:43:55 2021 +0000 [page info] Clean up PageInfoV2Desktop flag After launching page info, remove the flag and code that supports old bubble view. Bug: 1188101

From cr97 on, having this feature enabled means that the browser will attempt to reach the Optimization Guide Server every now and then at the https://optimizationguide-pa.googleapis.com endpoint, as it was detected by the npm run network-audit command: [:ERROR:brave_network_audit_browsertest.cc(151)] NETWORK AUDIT FAIL:https://optimizationguide-pa.googleapis.com/v1:GetModels?key=dummytoken [:ERROR:brave_network_audit_browsertest.cc(151)] NETWORK AUDIT FAIL:https://optimizationguide-pa.googleapis.com/v1:GetModels?key=dummytoken [...] [:ERROR:brave_network_audit_browsertest.cc(151)] NETWORK AUDIT FAIL:https://optimizationguide-pa.googleapis.com/v1:GetModels?key=dummytoken ../../brave/browser/net/brave_network_audit_browsertest.cc:249: Failure Value of: PerformNetworkAuditProcess(events) Actual: false Expected: true network-audit FAILED. Import /home/mario/work/brave-rebases/brave-browser/src/network_log.json in chrome://net-internals for more details. Stack trace: #0 0x55f213f6cc10 brave::(anonymous namespace)::BraveNetworkAuditTest::TearDownInProcessBrowserTestFixture() #1 0x55f215bda3be content::BrowserTestBase::SetUp() #2 0x55f215bd741e InProcessBrowserTest::SetUp() This patch disables the kkOptimizationHints feature. TBD if this is needed. This patch disables the kRemoteOptimizationGuideFetching features that are otherwise enabled by default, avoiding this URL requests. PS: I couldn't pinpoint yet where exactly in Chromium 97 this started happening, but I can consistently reproduce it on my local cr97 branch setting kMaxTimeoutPerLoadedURL in brave_network_audit_browsertest.cc to at least 20 seconds, while this doesn't happen on cr96 even when using the default timeout of 5 minutes, so it's cr97-related.

….4692.36.

Otherwise it falls back to MaterialButton and causes styling issues.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from Chromium 96 to Chromium 97 #10664

Upgrade from Chromium 96 to Chromium 97 #10664

Commits on Dec 7, 2021