-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use git commit ref for brave-ui dependency instead of npm-published version #1025
Conversation
ff4fd7d
to
10afaa7
Compare
If / when this is approved a merged, we should pick this up to as many branches as we're aiming to uplift future brave-ui updates to. But in each branch we should change the sha to the git commit ID of where that brave-core branch is currently pointing at brave-ui. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
10afaa7
to
78274a0
Compare
@cezaraugusto rebased because package.json had changed on master |
Use git commit ref for brave-ui dependency instead of npm-published version
Thanks @cezaraugusto. FYI brave-core 0.58.x is on brave-ui 0.34.6 which is brave/brave-ui@5c2d8a0 |
Use git commit ref for brave-ui dependency instead of npm-published version
0.58 9e43e62 |
This is the minimum change necessary to have brave-ui go direct to a specific commit in github, rather than a specific version published to npm.
It clears the way for the branch strategy outlined in brave/brave-browser#2315.
Addresses brave/brave-browser#2315
Test Plan:
npm install
in src/brave (don't remove node_modules first)cat ./node_modules/brave-ui/package.json | grep _from
. You should see"_from": "github:brave/brave-ui#9be9bee9764c6a1fd329acbe348f91b85142dc33",
npm run test-unit
"components/webpack/webpack.config.js
npm run build
from brave-browserSubmitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Reviewer Checklist: