Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedreader: Throw out srcset if they don't look like images #10238

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

kkuehlz
Copy link
Contributor

@kkuehlz kkuehlz commented Sep 23, 2021

Resolves brave/brave-browser#18280

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

In Issue

@kkuehlz kkuehlz requested review from antonok-edm and gpestana and removed request for antonok-edm September 23, 2021 23:05
Copy link
Collaborator

@antonok-edm antonok-edm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me (with the caveat that I have no clue what constitutes a valid or invalid srcset value!)

@kkuehlz kkuehlz merged commit 9c2695c into master Sep 24, 2021
@kkuehlz kkuehlz deleted the speedreader_srcset branch September 24, 2021 03:45
@stephendonner stephendonner added this to the 1.32.x - Nightly milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chunk of whitespace in middle of article
3 participants