Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedreader result explicit api #10195

Closed
wants to merge 2 commits into from
Closed

Conversation

kkuehlz
Copy link
Contributor

@kkuehlz kkuehlz commented Sep 22, 2021

Resolves brave/brave-browser#18231

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kkuehlz kkuehlz requested a review from iefremov as a code owner September 22, 2021 04:45
@kkuehlz kkuehlz self-assigned this Sep 22, 2021
@kkuehlz kkuehlz force-pushed the speedreader_result_explicit_api branch from d5dafa2 to c7b0852 Compare September 22, 2021 16:29
Kevin Kuehler added 2 commits September 22, 2021 10:42
Non-distilled sites can reach OnComplete(), so let's create a more
explicit API with a DistillStatus enum to check if distillation was
successful.

Resolves brave/brave-browser#18231
@kkuehlz kkuehlz force-pushed the speedreader_result_explicit_api branch from c7b0852 to 103ac3f Compare September 22, 2021 17:45
@kkuehlz kkuehlz closed this Oct 27, 2021
@kkuehlz kkuehlz removed their assignment Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eWEEK news page is Speedreader-enabled but probably shouldn't be
1 participant