Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes empty state flow #1017

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Fixes empty state flow #1017

merged 1 commit into from
Dec 4, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Dec 4, 2018

Resolves brave/brave-browser#2350

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • clean profile
  • enable rewards via settings page
  • make sure that you see no token
  • claim grant
  • make sure that you see wallet summary with grant in it

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Dec 4, 2018
@NejcZdovc NejcZdovc requested a review from bsclifton December 4, 2018 12:45
@NejcZdovc NejcZdovc force-pushed the empty-wallet branch 2 times, most recently from 0bcfc7f to 032ae3c Compare December 4, 2018 13:09
@NejcZdovc NejcZdovc requested a review from tmancey December 4, 2018 13:10
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! All tests pass and change looks good. Agreed- we'll want to rework this at a later time to move it out of OnWalletProperties. Great job 😄 👍

@bsclifton bsclifton merged commit 20172c4 into master Dec 4, 2018
@bsclifton bsclifton deleted the empty-wallet branch December 4, 2018 16:29
bsclifton added a commit that referenced this pull request Dec 4, 2018
bsclifton added a commit that referenced this pull request Dec 4, 2018
@bsclifton
Copy link
Member

bsclifton commented Dec 4, 2018

master 20172c4
0.59.x 9084490
0.58.x e35b93d
0.57.x 844bcca

bsclifton added a commit that referenced this pull request Dec 4, 2018
@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summary is not shown in settings page
3 participants