Skip to content

Commit

Permalink
Enable Safety Tips component and feature (fixes brave/brave-browser#1…
Browse files Browse the repository at this point in the history
  • Loading branch information
fmarier committed Jan 12, 2021
1 parent 188bac4 commit f9ee181
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions app/brave_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
#include "components/omnibox/common/omnibox_features.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/safe_browsing/core/features.h"
#include "components/security_state/core/features.h"
#include "components/sync/base/sync_base_switches.h"
#include "components/translate/core/browser/translate_prefs.h"
#include "components/variations/variations_switches.h"
Expand Down Expand Up @@ -212,6 +213,7 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
#if defined(OS_WIN)
features::kWinrtGeolocationImplementation.name,
#endif
security_state::features::kSafetyTipUI.name,
};

// Disabled features.
Expand Down
2 changes: 2 additions & 0 deletions app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "components/omnibox/common/omnibox_features.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/safe_browsing/core/features.h"
#include "components/security_state/core/features.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/common/content_features.h"
#include "third_party/blink/public/common/web_preferences/web_preferences.h"
Expand Down Expand Up @@ -89,6 +90,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, EnabledFeatures) {
&features::kWinrtGeolocationImplementation,
#endif
&net::features::kLegacyTLSEnforced,
&security_state::features::kSafetyTipUI,
};

for (const auto* feature : enabled_features)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ void ComponentInstaller::Register(ComponentUpdateService* cus,
"cmahhnpholdijhjokonmfdjbfmklppij", // Federated Learning of Cohorts
"eeigpngbgcognadeebkilcpcaedhellh", // Autofill States Data
"gcmjkmgdlgnkkcocmoeiminaijmmjnii", // Subresource Filter Rules
"jflookgnkcckhobaglndicnbbgbonegd", // Safety Tips
"llkgjffcdpffmhiakmfcdcblohccpfmo", // Origin Trials
"ojhpjlocmbogdgmfpkhlaaeamibhnphh", // Zxcvbn Data Dictionaries
#if defined(OS_ANDROID)
Expand Down

0 comments on commit f9ee181

Please sign in to comment.