NTP: Allow Remove widget option to be translatable

Fix brave/brave-browser#6869
brave · Jan 23, 2020 · ba90079 · ba90079
1 parent 695efa1
commit ba90079
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/browser/ui/webui/brave_webui_source.cc b/browser/ui/webui/brave_webui_source.cc
@@ -146,6 +146,7 @@ void CustomizeWebUIHTMLSource(const std::string &name,
         { "day", IDS_BRAVE_NEW_TAB_DAY },
         { "days", IDS_BRAVE_NEW_TAB_DAYS },
         { "photoBy", IDS_BRAVE_NEW_TAB_PHOTO_BY },
+        { "remove", IDS_BRAVE_NEW_TAB_REMOVE },
         { "preferencesPageTitle", IDS_BRAVE_NEW_TAB_PREFERENCES_PAGE_TITLE },
         { "bookmarksPageTitle", IDS_BRAVE_NEW_TAB_BOOKMARKS_PAGE_TITLE },
         { "historyPageTitle", IDS_BRAVE_NEW_TAB_HISTORY_PAGE_TITLE },

diff --git a/components/brave_new_tab_ui/components/default/widget/widgetMenu.tsx b/components/brave_new_tab_ui/components/default/widget/widgetMenu.tsx
@@ -8,6 +8,7 @@ import * as React from 'react'
 import { StyledWidgetMenuContainer, StyledWidgetMenu, StyledWidgetButton, StyledWidgetIcon, StyledSpan } from './styles'
 import { IconButton } from '../../default'
 import { CaratCircleODownIcon, CloseStrokeIcon } from 'brave-ui/components/icons'
+import { getLocale } from '../../../../common/locale'
 
 interface Props {
   menuPosition: 'right' | 'left'
@@ -79,7 +80,7 @@ export default class WidgetMenu extends React.PureComponent<Props, State> {
             onClick={this.unmountWidget}
           >
             <StyledWidgetIcon><CloseStrokeIcon/></StyledWidgetIcon>
-            <StyledSpan>Remove</StyledSpan>
+            <StyledSpan>{getLocale('remove')}</StyledSpan>
           </StyledWidgetButton>
         </StyledWidgetMenu>}
       </StyledWidgetMenuContainer>

diff --git a/components/resources/brave_components_strings.grd b/components/resources/brave_components_strings.grd
@@ -134,6 +134,7 @@
       <message name="IDS_BRAVE_NEW_TAB_DAY" desc="Displays the number of days.">day</message>
       <message name="IDS_BRAVE_NEW_TAB_DAYS" desc="Displays the number of days.">days</message>
       <message name="IDS_BRAVE_NEW_TAB_PHOTO_BY" desc="Prefix for photographer name">Photo by</message>
+      <message name="IDS_BRAVE_NEW_TAB_REMOVE" desc="Shown as an option for a widget to remove itself">Remove</message>
       <message name="IDS_BRAVE_NEW_TAB_PREFERENCES_PAGE_TITLE" desc="Title for preferences page">Edit Preferences</message>
       <message name="IDS_BRAVE_NEW_TAB_BOOKMARKS_PAGE_TITLE" desc="Title for bookmarks page">View and Manage Bookmarks</message>
       <message name="IDS_BRAVE_NEW_TAB_HISTORY_PAGE_TITLE" desc="Title for history page">View your browsing history</message>