Partition the EventSource pool per first-party on Desktop

- Sets the limit to 250 EventSources per first party. - Browser tests - Disable in Android for now fixes brave/brave-browser#28077
brave · Jan 31, 2023 · 992cbd0 · 992cbd0
1 parent b2e63de
commit 992cbd0
Show file tree

Hide file tree

Showing 11 changed files with 603 additions and 0 deletions.
diff --git a/android/android_browser_tests.gni b/android/android_browser_tests.gni
@@ -17,6 +17,7 @@ android_test_exception_sources = [
   "//brave/browser/brave_shields/brave_shields_web_contents_observer_browsertest.cc",
   "//brave/browser/brave_shields/cookie_expiry_browsertest.cc",
   "//brave/browser/brave_shields/domain_block_page_browsertest.cc",
+  "//brave/browser/brave_shields/eventsource_pool_limit_browsertest.cc",
   "//brave/browser/brave_shields/websockets_pool_limit_browsertest.cc",
   "//brave/browser/brave_wallet/brave_wallet_ethereum_chain_browsertest.cc",
   "//brave/browser/brave_wallet/brave_wallet_event_emitter_browsertest.cc",

diff --git a/browser/about_flags.cc b/browser/about_flags.cc
@@ -447,6 +447,11 @@ constexpr char kBraveChangeActiveTabOnScrollEventName[] =
 constexpr char kBraveChangeActiveTabOnScrollEventDescription[] =
     "Change the active tab when scroll events occur on tab strip.";
 #endif  // BUILDFLAG(IS_LINUX)
+
+constexpr char kRestrictEventSourcePoolName[] = "Restrict Event Source Pool";
+constexpr char kRestrictEventSourcePoolDescription[] =
+    "Limits simultaneous active WebSockets connections per eTLD+1";
+
 }  // namespace
 
 }  // namespace flag_descriptions
@@ -809,6 +814,11 @@ constexpr char kBraveChangeActiveTabOnScrollEventDescription[] =
       flag_descriptions::kBraveSyncHistoryDiagnosticsDescription,           \
       kOsAll, FEATURE_VALUE_TYPE(                                           \
           brave_sync::features::kBraveSyncHistoryDiagnostics)},             \
+    {"restrict-event-source-pool",                                          \
+      flag_descriptions::kRestrictEventSourcePoolName,                      \
+      flag_descriptions::kRestrictEventSourcePoolDescription,               \
+      kOsAll, FEATURE_VALUE_TYPE(                                           \
+          blink::features::kRestrictEventSourcePool)},                      \
     BRAVE_IPFS_FEATURE_ENTRIES                                              \
     BRAVE_NATIVE_WALLET_FEATURE_ENTRIES                                     \
     BRAVE_NEWS_FEATURE_ENTRIES                                              \