Merge pull request #15336 from brave/url_bubble_brave_protocol

Display brave:// protocol for internal urls when hovered
brave · Nov 3, 2022 · 75145ac · 75145ac
2 parents dd55670 + 7a808f8
commit 75145ac
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/browser/ui/brave_browser.cc b/browser/ui/brave_browser.cc
@@ -163,6 +163,17 @@ void BraveBrowser::ResetTryToCloseWindow() {
   Browser::ResetTryToCloseWindow();
 }
 
+void BraveBrowser::UpdateTargetURL(content::WebContents* source,
+                                   const GURL& url) {
+  GURL target_url = url;
+  if (url.SchemeIs(content::kChromeUIScheme)) {
+    GURL::Replacements replacements;
+    replacements.SetSchemeStr(content::kBraveUIScheme);
+    target_url = target_url.ReplaceComponents(replacements);
+  }
+  Browser::UpdateTargetURL(source, target_url);
+}
+
 bool BraveBrowser::ShouldAskForBrowserClosingBeforeHandlers() {
   if (g_suppress_dialog_for_testing)
     return false;

diff --git a/browser/ui/brave_browser.h b/browser/ui/brave_browser.h
@@ -46,6 +46,7 @@ class BraveBrowser : public Browser {
   bool TryToCloseWindow(
       bool skip_beforeunload,
       const base::RepeatingCallback<void(bool)>& on_close_confirmed) override;
+  void UpdateTargetURL(content::WebContents* source, const GURL& url) override;
   void ResetTryToCloseWindow() override;
 
   void TabStripEmpty() override;