Skip to content

Commit

Permalink
No Bug: Add brave player copy text (brave/brave-ios#8388)
Browse files Browse the repository at this point in the history
  • Loading branch information
cuba authored Nov 10, 2023
1 parent 619c462 commit 734d5c4
Show file tree
Hide file tree
Showing 2 changed files with 92 additions and 2 deletions.
92 changes: 92 additions & 0 deletions Sources/BraveShields/ShieldStrings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,95 @@ public extension Strings.Shields {
comment: "The option the user can select to do standard (non-aggressive) ad and tracker blocking"
)
}

// MARK: - Anti Ad-Block Warning

public extension Strings.Shields {
/// A title for a popup that tells the user we recommend turning shields off for this site
static let antiAdBlockWarningTitle = NSLocalizedString(
"AntiAdBlockWarningTitle", tableName: "BraveShared", bundle: .module,
value: "Adjust Ad Block Settings For This Site",
comment: "A title for a popup that tells the user we recommend turning shields off for this site."
)

/// A descriptive message explaining this site's ad-blocking crackdown
static let antiAdBlockWarningDescription = NSLocalizedString(
"AntiAdBlockWarningDescription", tableName: "BraveShared", bundle: .module,
value: "This site has begun blocking some ad blockers, which means their site may not work as expected.",
comment: "A descriptive message explaining this site's ad-blocking crackdown."
)

/// A descriptive message explaining to disable shields on this site
static let antiAdBlockWarningDescription2 = NSLocalizedString(
"AntiAdBlockWarningDescription2", tableName: "BraveShared", bundle: .module,
value: "To address this issue, Brave can adjust your shields settings for you. Once adjusted, you can try watching this content in Brave Player instead.",
comment: "A descriptive message explaining to disable shields on this site."
)

/// A button that disables ad-blocking and uses brave player
static let antiAdBlockWarningConfirmationButton = NSLocalizedString(
"AntiAdBlockWarningConfirmationButton", tableName: "BraveShared", bundle: .module,
value: "Adjust Shields For Me",
comment: "A button that disables ad-blocking and uses brave player."
)

/// A button that dismisses the warning and does nothing
static let antiAdBlockWarningDismissButton = NSLocalizedString(
"AntiAdBlockWarningDismissButton", tableName: "BraveShared", bundle: .module,
value: "Keep Current Settings",
comment: "A button that dismisses the warning and does nothing."
)

/// A discription of the Brave Player
static let antiAdBlockWarningBravePlayerDescription = NSLocalizedString(
"AntiAdBlockWarningBravePlayerDescription", tableName: "BraveShared", bundle: .module,
value: "**Brave Player** is your ticket to an ad-free and uninterrupted video experience.",
comment: "A discription of the Brave Player."
)
}

// MARK: - Brave Player

public extension Strings.Shields {
/// Title for the brave player feature
static let bravePlayer = NSLocalizedString(
"BravePlayer", tableName: "BraveShared", bundle: .module,
value: "Brave Player",
comment: "Title for the brave player feature"
)

/// Title for the brave player info popup which appears when clicking on the brave player icon on the navigation bar
static let bravePlayerInfoTitle = NSLocalizedString(
"BravePlayerInfoTitle", tableName: "BraveShared", bundle: .module,
value: "Watch In Brave Player Instead",
comment: "Title for the brave player info popup which appears when clicking on the brave player icon on the navigation bar."
)

/// A description of the brave player that is presented on the info panel when clicing on the brave player icon for the first time
static let bravePlayerInfoMessage = NSLocalizedString(
"BravePlayerInfoMessage", tableName: "BraveShared", bundle: .module,
value: "Brave Player lets you watch videos without interruptions.",
comment: "A description of the brave player that is presented on the info panel when clicing on the brave player icon for the first time."
)

/// A label for a toggle that enables automatic launching of brave player for certain sites
static let bravePlayerAlwaysOpenVideoLinks = NSLocalizedString(
"BravePlayerAlwaysOpenYouTubeLinks", tableName: "BraveShared", bundle: .module,
value: "Always open videos from this site with Brave Player",
comment: "A label for a toggle that enables automatic launching of brave player for certain sites"
)

/// A button that confirms to use the brave player
static let bravePlayerConfirmButton = NSLocalizedString(
"BravePlayerConfirmButton", tableName: "BraveShared", bundle: .module,
value: "Try It Out",
comment: "A button that confirms to use the brave player."
)

/// A button that ignores the brave player
static let bravePlayerDismissButton = NSLocalizedString(
"BravePlayerDismissButton", tableName: "BraveShared", bundle: .module,
value: "Not Now",
comment: "A button that ignores the brave player"
)
}
2 changes: 0 additions & 2 deletions Sources/BraveStrings/BraveStrings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1422,7 +1422,6 @@ extension Strings {
public static let siteReportedTitle = NSLocalizedString("SiteReportedTitle", tableName: "BraveShared", bundle: .module, value: "Thank You", comment: "")
public static let siteReportedBody = NSLocalizedString("SiteReportedBody", tableName: "BraveShared", bundle: .module, value: "Thanks for letting Brave's developers know that there's something wrong with this site. We'll do our best to fix it!", comment: "")


// MARK: Submit report
public static let reportABrokenSite = NSLocalizedString("ReportABrokenSite", tableName: "BraveShared", bundle: .module, value: "Report a Broken Site", comment: "")
public static let reportBrokenSiteBody1 = NSLocalizedString("ReportBrokenSiteBody1", tableName: "BraveShared", bundle: .module, value: "Let Brave's developers know that this site doesn't work properly with Shields:", comment: "First part of the report a broken site copy. After the colon is a new line and then a website address")
Expand All @@ -1442,7 +1441,6 @@ extension Strings {
comment: "A label for a text entry field where the user can provide contact details within a web-compatibilty report"
)


public static let reportBrokenContactMeSuggestions = NSLocalizedString(
"ReportBrokenContactMeSuggestions", tableName: "BraveShared", bundle: .module,
value: "Email, Twitter, etc.",
Expand Down

0 comments on commit 734d5c4

Please sign in to comment.