Skip to content

Commit

Permalink
Fix settings UI issues
Browse files Browse the repository at this point in the history
  • Loading branch information
ShivanKaul committed Apr 13, 2023
1 parent fdf8b55 commit 6d9e822
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions browser/resources/settings/brave_overrides/privacy_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function InsertLocalhostAccessSubpage (
'[Brave Settings Overrides] Couldn\'t find localhost access subpage')
} else {
localhostAccessSubpage.setAttribute('page-title',
I18nBehavior.i18n('siteSettingsCategoryLocalhostAccess'))
loadTimeData.getString('siteSettingsCategoryLocalhostAccess'))
const localhostAccessDefault =
localhostAccessTemplate.content.getElementById('localhostAccessDefault')
if (!localhostAccessDefault) {
Expand All @@ -118,10 +118,10 @@ function InsertLocalhostAccessSubpage (
} else {
localhostAccessDefault.setAttribute(
'toggle-off-label',
I18nBehavior.i18n('siteSettingsLocalhostAccessAsk'))
loadTimeData.getString('siteSettingsLocalhostAccessAsk'))
localhostAccessDefault.setAttribute(
'toggle-on-label',
I18nBehavior.i18n('siteSettingsLocalhostAccessAsk'))
loadTimeData.getString('siteSettingsLocalhostAccessAsk'))
}
const localhostExceptions =
localhostAccessTemplate.content.getElementById('localhostExceptions')
Expand All @@ -131,10 +131,10 @@ function InsertLocalhostAccessSubpage (
} else {
localhostExceptions.setAttribute(
'block-header',
I18nBehavior.i18n('siteSettingsLocalhostAccessBlockExceptions'))
loadTimeData.getString('siteSettingsLocalhostAccessBlockExceptions'))
localhostExceptions.setAttribute(
'allow-header',
I18nBehavior.i18n('siteSettingsLocalhostAccessAllowExceptions'))
loadTimeData.getString('siteSettingsLocalhostAccessAllowExceptions'))
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion browser/resources/settings/brave_overrides/site_details.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ RegisterPolymerTemplateModifications({
'[Brave Settings Overrides] Localhost access settings not found')
} else {
localhostAccessSettings.setAttribute(
'label', I18nBehavior.i18n('siteSettingsLocalhostAccess'))
'label', loadTimeData.getString('siteSettingsLocalhostAccess'))
}
curChild++
}
Expand Down

0 comments on commit 6d9e822

Please sign in to comment.