-
Notifications
You must be signed in to change notification settings - Fork 890
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Commented out testonly attribute from chromedriver build files.
Needed by //brave:brave_chromedriver_dist_resources Chromium change: commit 5c1bccba168c40684560b571a4004c2502791608 Author: Daniel Bratell <[email protected]> Date: Tue Apr 23 17:37:02 2019 +0000 Fixing and enabling dependency checks for chromedriver Since we had a bug because of this missing check, let's not repeat it. Bug: 949535
- Loading branch information
Showing
2 changed files
with
26 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/chrome/test/chromedriver/BUILD.gn b/chrome/test/chromedriver/BUILD.gn | ||
index ab46b4e2de94f567e2f010f6badae325db24ac61..0929168b9f17b4aa2bdd6e721bf71af8909d90d0 100644 | ||
--- a/chrome/test/chromedriver/BUILD.gn | ||
+++ b/chrome/test/chromedriver/BUILD.gn | ||
@@ -304,7 +304,7 @@ source_set("lib") { | ||
} | ||
|
||
executable("chromedriver") { | ||
- testonly = true | ||
+# testonly = true | ||
sources = [ | ||
"server/chromedriver_server.cc", | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/net/traffic_annotation/BUILD.gn b/net/traffic_annotation/BUILD.gn | ||
index 771970a0462592317bcc061c7763eb55e67458df..66e73e69e4cf1e79ece8f49f59ad0c30f87647b2 100644 | ||
--- a/net/traffic_annotation/BUILD.gn | ||
+++ b/net/traffic_annotation/BUILD.gn | ||
@@ -8,7 +8,7 @@ source_set("traffic_annotation") { | ||
} | ||
|
||
source_set("test_support") { | ||
- testonly = true | ||
+# testonly = true | ||
sources = [ | ||
"network_traffic_annotation_test_helper.h", | ||
] |