Remove "Ask when a site wants to install Widevine on your computer" p…

…reference from UI Preference itself is still used- but not displayed to user. If they click "Don't show again" and then change their mind, they can enable regular Widevine preference Fixes brave/brave-browser#14130
brave · Feb 17, 2021 · 6167de9 · 6167de9
1 parent e951c4e
commit 6167de9
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 11 deletions.
diff --git a/app/brave_generated_resources.grd b/app/brave_generated_resources.grd
@@ -202,9 +202,6 @@
       <message name="IDS_SETTINGS_ENABLE_WIDEVINE_DESC" desc="Text fragment for enabling widevine component. 'Widevine' is the name of a plugin and should not be translated.">
         Use Widevine digital rights management (DRM) component to view protected streaming video and other content in the browser.
       </message>
-      <message name="IDS_SETTINGS_ASK_WIDEVINE_INSTALL_DESC" desc="Text fragment for asking widevine install or not">
-        Ask when a site wants to install Widevine on your computer.
-      </message>
       <message name="IDS_SETTINGS_ENABLE_TOR_TITLE" desc="Text fragment for enabling tor component">
         Private window with Tor
       </message>

diff --git a/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.html b/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.html
@@ -117,12 +117,6 @@
         sub-label="$i18n{webTorrentEnabledDesc}"
         on-settings-boolean-control-change="onWebTorrentEnabledChange_">
     </settings-toggle-button>
-    <settings-toggle-button
-        class="cr-row"
-        pref="{{prefs.brave.ask_widevine_install}}"
-        label="Widevine"
-        sub-label="$i18n{appearanceSettingsAskWidevineInstallDesc}">
-    </settings-toggle-button>
     <settings-toggle-button
         id="widevineEnabled"
         class="cr-row"

diff --git a/chromium_src/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc b/chromium_src/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
@@ -66,8 +66,6 @@ void BraveAddCommonStrings(content::WebUIDataSource* html_source,
     {"siteSettingsCategoryAutoplay", IDS_SETTINGS_SITE_SETTINGS_AUTOPLAY},
     {"braveGetStartedTitle", IDS_SETTINGS_BRAVE_GET_STARTED_TITLE},
     {"braveAdditionalSettingsTitle", IDS_SETTINGS_BRAVE_ADDITIONAL_SETTINGS},
-    {"appearanceSettingsAskWidevineInstallDesc",
-     IDS_SETTINGS_ASK_WIDEVINE_INSTALL_DESC},
     {"appearanceSettingsBraveTheme",
      IDS_SETTINGS_APPEARANCE_SETTINGS_BRAVE_THEMES},
     {"appearanceSettingsLocationBarIsWide",