Merge pull request #184 from emerick/publisher-branded-site-banners

Support publisher branded site banners
brave · Dec 4, 2018 · 48344ee · 48344ee
1 parent 16bfe91
commit 48344ee
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/bat_publishers.cc b/src/bat_publishers.cc
@@ -864,10 +864,16 @@ void BatPublishers::getPublisherBanner(const std::string& publisher_id,
 
       banner.title = values.banner.title_;
       banner.description = values.banner.description_;
-      banner.background = values.banner.background_;
-      banner.logo = values.banner.logo_;
       banner.amounts = values.banner.amounts_;
       banner.social = values.banner.social_;
+
+      // WebUI must not make external network requests, so map
+      // external resopurces to chrome://rewards-image and handle them
+      // via our custom data source
+      if (!values.banner.background_.empty())
+        banner.background = "chrome://rewards-image/" + values.banner.background_;
+      if (!values.banner.logo_.empty())
+        banner.logo = "chrome://rewards-image/" + values.banner.logo_;
     }
   }
 
@@ -888,7 +894,6 @@ void BatPublishers::getPublisherBanner(const std::string& publisher_id,
                                       _2);
 
   ledger_->GetPublisherInfo(filter, callbackGetPublisher);
-
 }
 
 void BatPublishers::onPublisherBanner(ledger::PublisherBannerCallback callback,