Reverted PR#16478 (Display history sync diagnostic info)

brave · Sep 28, 2023 · 43100dd · 43100dd
1 parent 5f3871d
commit 43100dd
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 125 deletions.
diff --git a/browser/about_flags.cc b/browser/about_flags.cc
@@ -842,15 +842,6 @@
           kOsDesktop | kOsAndroid,                                             \
           FEATURE_VALUE_TYPE(translate::kTranslate),                           \
       },                                                                       \
-      {                                                                        \
-          "brave-sync-history-diagnostics",                                    \
-          "Enable Brave Sync History Diagnostics",                             \
-          "Brave Sync History Diagnostics flag displays additional sync "      \
-          "related information on History page",                               \
-          kOsAll,                                                              \
-          FEATURE_VALUE_TYPE(                                                  \
-              brave_sync::features::kBraveSyncHistoryDiagnostics),             \
-      },                                                                       \
       {                                                                        \
           "restrict-event-source-pool",                                        \
           "Restrict Event Source Pool",                                        \

diff --git a/build/config/brave_build.gni b/build/config/brave_build.gni
@@ -20,7 +20,6 @@ import("//brave/components/content_settings/core/browser/sources.gni")
 import("//brave/components/omnibox/browser/sources.gni")
 import("//brave/components/search_engines/sources.gni")
 import("//brave/components/sync/service/sources.gni")
-import("//brave/components/sync/sources.gni")
 import("//brave/components/sync_device_info/sources.gni")
 import("//brave/components/update_client/sources.gni")
 import("//brave/installer/linux/sources.gni")

diff --git a/chromium_src/components/history/core/browser/history_backend.cc b/chromium_src/components/history/core/browser/history_backend.cc
diff --git a/components/brave_sync/features.cc b/components/brave_sync/features.cc
@@ -12,14 +12,5 @@ namespace features {
 
 BASE_FEATURE(kBraveSync, "BraveSync", base::FEATURE_ENABLED_BY_DEFAULT);
 
-// When this feature is enabled through brave://flags it adds to history entry's
-// title additional info for sync diagnostics:
-// - whether history entry should be synced;
-// - typed count;
-// - page transition.
-BASE_FEATURE(kBraveSyncHistoryDiagnostics,
-             "BraveSyncHistoryDiagnostics",
-             base::FEATURE_DISABLED_BY_DEFAULT);
-
 }  // namespace features
 }  // namespace brave_sync
diff --git a/components/brave_sync/features.h b/components/brave_sync/features.h
@@ -13,8 +13,6 @@ namespace features {
 
 BASE_DECLARE_FEATURE(kBraveSync);
 
-BASE_DECLARE_FEATURE(kBraveSyncHistoryDiagnostics);
-
 }  // namespace features
 }  // namespace brave_sync
 

diff --git a/components/sync/sources.gni b/components/sync/sources.gni
diff --git a/patches/components-sync-BUILD.gn.patch b/patches/components-sync-BUILD.gn.patch