Fix deletion of urls (#11338)

brave · Nov 30, 2021 · 2966283 · 2966283
1 parent 250517b
commit 2966283
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/browser/resources/settings/brave_wallet_page/add_wallet_network_dialog.html b/browser/resources/settings/brave_wallet_page/add_wallet_network_dialog.html
@@ -98,7 +98,6 @@
                     spellcheck="false"
                     on-input=urlChangedRpc_
                     value="{{item.value}}"
-                    class="mandatory"
                     autofocus>
           </cr-input>
         </template>

diff --git a/browser/resources/settings/brave_wallet_page/add_wallet_network_dialog.js b/browser/resources/settings/brave_wallet_page/add_wallet_network_dialog.js
@@ -182,7 +182,7 @@ Polymer({
   },
   updateSubmitButtonState_: function() {
     for (const input of this.shadowRoot.querySelectorAll('.mandatory')) {
-      if (input && (input.invalid || !input.value || input.value.trim() === '')) {
+      if (input && (input.invalid || !input.value || (input.value.trim && input.value.trim() === ''))) {
         this.isSubmitButtonEnabled_ = false
         return;
       }
@@ -202,8 +202,7 @@ Polymer({
       this.isSubmitButtonEnabled_ = false
       return;
     }
-
-    if (!this.rpcUrls.find(element => element.value !== '')) {
+    if (!this.hasValidRPCUrls()) {
       this.isSubmitButtonEnabled_ = false
       return;
     }
@@ -221,14 +220,17 @@ Polymer({
     this.updateSubmitButtonState_()
     const empty = element.value.trim() === ''
     if (list == 'rpc' && element.invalid) {
-      const text = empty ? this.i18n('walletAddNetworkMandarotyFieldError')
+      const text = empty && !this.hasValidRPCUrls() ? this.i18n('walletAddNetworkMandarotyFieldError')
                          : this.i18n('walletAddNetworkInvalidURLInput')
       element.setAttribute('error-message', text)
     }
     if (!element.invalid || empty) {
       this.updatePlusButtonState(list)
     }
   },
+  hasValidRPCUrls: function() {
+    return this.rpcUrls.find(element => this.validateURL(element.value))
+  },
   urlChangedIcons_: function(event) {
     return this.urlChangedImpl_(event.target, 'icon')
   },