Merge pull request #42 from brave/shields/419

do not allow showing resources blocked if there's none
brave · Jul 3, 2018 · 1be1f9c · 1be1f9c
2 parents 6305b0d + 33e4d05
commit 1be1f9c
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/components/braveShields/braveShieldsStats.tsx b/app/components/braveShields/braveShieldsStats.tsx
@@ -88,13 +88,13 @@ export default class BraveShieldsStats extends React.Component<BraveShieldsStats
       fingerprintingBlockedDetailsOpen
     } = this.state
 
-    if (adsTrackersBlockedDetailsOpen) {
+    if (adsTrackersBlockedDetailsOpen && this.totalAdsTrackersBlocked > 0) {
       return this.setResourceBlockedItemView(this.totalAdsTrackersBlockedResources)
-    } else if (httpsRedirectedDetailsOpen) {
+    } else if (httpsRedirectedDetailsOpen && this.httpsRedirected > 0) {
       return this.setResourceBlockedItemView(this.httpsRedirectedResources)
-    } else if (javascriptBlockedDetailsOpen) {
+    } else if (javascriptBlockedDetailsOpen && this.javascriptBlocked > 0) {
       return this.setResourceBlockedItemView(this.javascriptBlockedResources)
-    } else if (fingerprintingBlockedDetailsOpen) {
+    } else if (fingerprintingBlockedDetailsOpen && this.fingerprintingBlocked > 0) {
       return this.setResourceBlockedItemView(this.fingerprintingBlockedResources)
     } else {
       return null