Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated submodule update (submodules/uBlock) #829

Merged
merged 10 commits into from
Apr 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Review brave/uBlock for any recent format changes.

@github-actions github-actions bot requested a review from antonok-edm as a code owner January 29, 2024 07:13
@antonok-edm
Copy link
Collaborator

There was a change to scriptletGlobals, which is now a plain JS object (no longer a Map). Will have to investigate compatibility.

Copy link
Collaborator

@antonok-edm antonok-edm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add a Proxy implementation in brave-core to allow graceful migration to these changes

@antonok-edm
Copy link
Collaborator

antonok-edm commented Feb 2, 2024

brave-core supports this as of 1.62 release 4 (Brave 1.62.162, released Feb 7)

brave-ios also should support it as of 1.62 (released Feb 15)

@antonok-edm
Copy link
Collaborator

reviewed newer commits up to this point, no other concerns so far

@antonok-edm
Copy link
Collaborator

reviewed newer commits again, still no other concerns

Copy link
Collaborator

@antonok-edm antonok-edm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting reports of YT ads via Shorts, requiring the new [-] feature in json-prune-fetch-response. Let's get this merged.

@antonok-edm antonok-edm merged commit 72bf14f into master Apr 19, 2024
2 checks passed
@antonok-edm antonok-edm deleted the automated-submodule-update branch April 19, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant