Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace chrome branding on win8 welcome page with brave one #1857

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Replace chrome branding on win8 welcome page with brave one #1857

merged 1 commit into from
Oct 26, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 26, 2018 •
edited
Loading

Close #1335

This should be merged with brave/brave-core#741.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Newly install on win8

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@simonhong simonhong requested a review from bbondy October 26, 2018 04:37
@simonhong simonhong self-assigned this Oct 26, 2018
@bbondy bbondy merged commit e5b0ce1 into master Oct 26, 2018
bbondy added a commit that referenced this pull request Oct 26, 2018
@bbondy
Merge pull request #1857 from brave/replace_chrome_branding_in_win8_w…
efafb80 
…elcomepage

Replace chrome branding on win8 welcome page with brave one
bbondy added a commit that referenced this pull request Oct 26, 2018
@bbondy
Merge pull request #1857 from brave/replace_chrome_branding_in_win8_w…
5471e8f 
…elcomepage

Replace chrome branding on win8 welcome page with brave one
@bbondy
Copy link
Member

bbondy commented Oct 26, 2018 •
edited
Loading

master: e5b0ce1
0.57.x: efafb80
0.56.x: 5471e8f

@simonhong simonhong deleted the replace_chrome_branding_in_win8_welcomepage branch October 30, 2018 01:09
@bbondy bbondy removed the 0.56.x label Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
0.56.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @bbondy