Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from 70.0.3538.16 to 70.0.3538.22 #1250

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Update from 70.0.3538.16 to 70.0.3538.22 #1250

merged 1 commit into from
Sep 24, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 24, 2018

Fix #1249

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bbondy bbondy self-assigned this Sep 24, 2018
@bbondy bbondy mentioned this pull request Sep 24, 2018
Merged
11 tasks
SergeyZhukovsky
SergeyZhukovsky approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy merged commit a6b443c into master Sep 24, 2018
bbondy added a commit that referenced this pull request Sep 24, 2018
@bbondy
Merge pull request #1250 from brave/70.0.3538.22
d19f1da 
Update from 70.0.3538.16 to 70.0.3538.22
@bbondy
Copy link
Member Author

bbondy commented Sep 30, 2018

master: a6b443c
0.56.x: a6b443c
0.55.x: d19f1da

@bbondy bbondy deleted the 70.0.3538.22 branch October 14, 2018 14:40
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @SergeyZhukovsky