Introduce --ignore_compile_failure to build script #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
ignore_compile_failure
branch
from
d3b5b79 to
44efa8e
Compare
This option compiles files as many as possible regardless of compile error. It would be useful when we trigger full build before going to bed.
simonhong
force-pushed
the
ignore_compile_failure
branch
from
44efa8e to
e214c6f
Compare
bbondy
reviewed
Oct 1, 2018
| @@ -187,9 +187,13 @@ const util = { | |||
|
|
|||
| if (process.platform === 'win32') util.updateOmahaMidlFiles() | |||
|
|
|||
| let num_compile_failure = 1 | |||
| if (config.ignore_compile_failure) | |||
| num_compile_failure = 1000 | |||
There was a problem hiding this comment.
maybe we want to allow more than 1k? I'm thinking chromium rebase sometimes might surpass since 1 real error can be much more. Merging in any case though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option compiles files as many as possible regardless of compile error.
It would be useful when we trigger full build before going to bed.
Close #1204
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: