Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Chromium 70.0.3538.16 #1131

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Upgrade to Chromium 70.0.3538.16 #1131

merged 1 commit into from
Sep 17, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 14, 2018

Please review but don't merge yet, I'm still running builds and tests.

Fix #1130

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bbondy bbondy self-assigned this Sep 14, 2018
@bbondy bbondy requested a review from darkdh September 14, 2018 20:10
@bbondy bbondy merged commit d3d72c2 into master Sep 17, 2018
emerick pushed a commit that referenced this pull request Sep 17, 2018
@bbondy @emerick
Merge pull request #1131 from brave/70.0.3538.16
0024aed 
Upgrade to Chromium 70.0.3538.16
@emerick
Copy link
Contributor

emerick commented Sep 17, 2018 •
edited
Loading

master: d3d72c2
0.55.x: 0024aed

@bbondy bbondy deleted the 70.0.3538.16 branch October 14, 2018 14:40
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@bbondy @emerick @darkdh