Fix missing resource copy files #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP will be removed when finishing mac and window completes building.(linux is not available for now) |
simonhong
force-pushed
the
resource_copy
branch
5 times, most recently
from
ff63e15
to
cbe1fc4
Compare
simonhong
force-pushed
the
resource_copy
branch
from
cbe1fc4
to
6cef6c6
Compare
|
I didn't see any problem on Win and MacOS with this PR. |
simonhong
changed the title
|
Clean build on Linux is also fine. |
bbondy
approved these changes
Sep 10, 2018
|
btw only the issue should have a milestone specified for the release. The label on the PR gets added once it is merged to that branch. Thanks! |
bbondy
added a commit
that referenced
this pull request
Sep 10, 2018
Fix missing resource copy files
|
0.55.x dab701c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying sources that have multiple target isn't handled properly.
Copying sources that have nested directory isn't handled properly.
Some grd files are not copied properly.
Not handled for the case that BRANDING file and icon file are not existed.
Close #1035
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: