Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 10279: Set updater endpoint at build time #10281

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Jun 15, 2020

Resolves #10279

Submitter Checklist:

Test Plan:

  1. Set the updater config.
  2. Setup Little Snitch or Fiddler to intercept requests
  3. Open Brave Browser with a clean profile
  4. Navigate to brave://components, verify the following components download successfully:
  5. Repeat the above steps with a clean profile and --use-dev-goupdater-url flag.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde self-assigned this Jun 15, 2020
@jumde jumde force-pushed the updater_endpoint branch 5 times, most recently from fc6c8fe to fe2deef Compare June 17, 2020 15:04
@jumde jumde requested a review from mihaiplesa June 17, 2020 16:55
@jumde jumde force-pushed the updater_endpoint branch 6 times, most recently from e63149c to 272acc7 Compare June 22, 2020 16:17
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jumde jumde merged commit ed982ab into master Jun 23, 2020
@jumde jumde deleted the updater_endpoint branch June 23, 2020 00:28
@jumde jumde added this to the 1.12.x - Nightly milestone Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Set the updater endpoint at build time
3 participants