Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC isn't going through for the connected publisher from KYC'd uphold account #9962

Closed
GeetaSarvadnya opened this issue May 27, 2020 · 5 comments · Fixed by brave/brave-core#5671

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 27, 2020

Description

Found while testing #8938

AC isn't going through for the connected publisher from KYC'd uphold account. One time tip and recurring tips are getting added to the Pending contribution list as expected.
AC for the connected pub is tested from both self-funded and ads grants claimed wallets, in both types of funds AC is not going through for connected pubs.

Steps to Reproduce

  1. Clean profile 1.10.x staging environment
  2. Enable rewards
  3. Connect KYC'd uphold staging account ( should have some balance (self funded or ad grants))
  4. Send a one time tip and recurring tip to connected pub DDG
  5. Add connected pub DDG to AC table
  6. Wait for AC to trigger
  7. AC didn't happen, wallet balance didn't go down.
  8. Click on BAT logo displays the error message as There was a problem processing your contribution

Note: AC is going through in Release channel (1.9.x) even though we get There was a problem processing your contribution message on BAT logo

Actual result:

AC isn't going through for the connected publisher from KYC'd uphold account
image

Expected result:

AC should go through for the connected publisher from KYC'd uphold account

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NO
  • Can you reproduce this issue with the beta channel? No sure
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya is recurring tip to connected publisher going through?

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented May 27, 2020

@NejcZdovc Nope, recurring tips are getting added in a Pending contribution list after AC and which is expected I think.

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya and what is the source of funds for AC and recurring tips?

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented May 27, 2020

@NejcZdovc I have self-funded the brave uphold wallet via uphold staging wallet. I have tested even with Ad grants claimed (which got added into uphold account) - For both type of funds AC isn't going through for connected pubs

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jun 2, 2020

Verification passed on

Brave | 1.10.80 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Note: Triggered AC by adding one verified pub DDG into AC table

Test plan 1:

  • Verified that AC is happening successfully, AC notification is shown on BAT logo and amount got deducted from self-funded uphold wallet
    image
  • Verified the transaction recorded in uphold
    image

Test plan 2:

  • Verified that user can send one-time tip to verified from UGP grants and amount deducted from wallet balance
  • Verified one-time tip recorded in both summary and tips panel
    image
    image

Additional testing:

  • Verified AC is triggered from UGP grants recurring tips and one-time tips are processed.
    image

  • Verified that AC is triggered and monthly tips and one-time tips are processed using restored user funds
    image

  • Verified AC is triggered for connected pubs from KYC'd uphold account which is holding ad grants.
    image

Verification passed on

Brave 1.10.82 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified Test plan 1:
image
image
image

Verified Test plan 2:
image

  • Verified AC is triggered from UGP grants recurring tips and one-time tips are processed.
    image

Verified passed with

Brave 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS macOS Version 10.14.6 (Build 18G3020)

Plan 1 - confirmed AC went thru for connected publisher on staging env (ddg)

Screen Shot 2020-06-11 at 3 55 19 PM

Screen Shot 2020-06-11 at 3 57 42 PM

Screen Shot 2020-06-11 at 3 58 53 PM

Screen Shot 2020-06-11 at 3 58 59 PM

Plan 2 - confirmed tip went thru for connected publisher on staging env (ddg)

Screen Shot 2020-06-11 at 4 02 53 PM

Screen Shot 2020-06-11 at 4 02 59 PM

Screen Shot 2020-06-11 at 4 03 07 PM

Screen Shot 2020-06-11 at 4 03 14 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment