Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Widevine prompt should include more DRM background information #9907

Closed
Madis0 opened this issue May 22, 2020 · 12 comments · Fixed by brave/brave-core#11837
Closed

Comments

@Madis0
Copy link

Madis0 commented May 22, 2020

Description

Running EME on a site for the first time makes Brave ask the user, whether they'd like to install it. While that's a good thing, it also has a big piece of text, explaining:

  • Widevine is from Google
  • it's bad but you choose
  • we take no responsibility

However, it lacks information on:

Steps to Reproduce

  1. Open https://permission.site/
  2. Click "Encrypted Media (EME)"
  3. Note the popup

Actual result:

Popup

Expected result:

Expected a short popup with one-sentence description and a link to read more. Something more like Firefox, but with an actual explanation.

Example text:

Widewine is a Digital Rights Management plugin by Google, used to give users access to protected content by displaying it in a controlled environment. Read more

The "read more" should link to a Brave article explaining what a DRM is, how it works, why it's bad, how Widevine works and how to install/enable/disable/remove it.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.10.60

Version/Channel Information:

  • Can you reproduce this issue with the current release? Probably
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Probably
  • Can you reproduce this issue with the nightly channel? Probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

Related: #2791

@rebron rebron self-assigned this Jul 10, 2020
@rebron rebron added plugin/Widevine OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 10, 2020
@rebron rebron changed the title Install Widevine prompt should be more readable [Desktop] Install Widevine prompt should be more readable Jul 10, 2020
@rebron rebron added the needs-text-change This change requires some careful wording. label Oct 6, 2021
@rebron
Copy link
Collaborator

rebron commented Oct 6, 2021

cc: @rmcfadden3 If you think we should revisit update our widevine screen.

@rebron rebron changed the title [Desktop] Install Widevine prompt should be more readable Install Widevine prompt should include more DRM background information Oct 6, 2021
@rmcfadden3
Copy link

@rebron — sorry for the delayed reply on this one. I'm actually OK with the text here. Yes, it's long. But 1) it seems good that users have all the info here rather than having to click through to a help page, and 2) my sense is this is not a commonly seen message, so it wouldn't affect very many users.

But correct me if I'm mistaken in those assumptions and you think we should edit.

@Madis0
Copy link
Author

Madis0 commented Oct 15, 2021

  1. my sense is this is not a commonly seen message, so it wouldn't affect very many users.

Pretty sure Netflix, Amazon Prime and the like are commonly used and everyone would see this text on their first try.

@rmcfadden3
Copy link

Ah, didn't realize how frequently this message might appear.

Will investigate new / better copy, and a corresponding help doc with more info that people could click through to.

@rebron
Copy link
Collaborator

rebron commented Dec 9, 2021

cc: @Brave-Matt We'll be updating the text here and will need to Support documentation to match.

@rmcfadden3
Copy link

rmcfadden3 commented Dec 9, 2021

@rebron — here's new copy for the Widevine message. Note the "Learn more" will point to a support page that explains more. Also note the "X" beside the header is meant to allow user to close the message without making a decision.

Header:

  • [sitename] is asking you to install Google Widevine X

Body:

  • Widevine is sometimes needed to play media on a webpage. It’s a Google extension loaded from Google servers, which Brave cannot inspect. By installing, you’ll agree to Google’s terms of use. Learn more. [https://support.brave.com/hc/en-us/articles/360023851591-How-do-I-view-DRM-protected-content-]

CTAs:

  • Block
  • Allow
  • Change later at brave://settings/extensions

@rebron rebron removed their assignment Jan 12, 2022
@rebron rebron added the l10n label Jan 12, 2022
@simonhong simonhong self-assigned this Jan 12, 2022
@rebron
Copy link
Collaborator

rebron commented Jan 12, 2022

@rmcfadden3 What did you want to do with the Change later at brave://settings/extensions CTA? Do we want to just include it as text and link in the body or how did you want to incorporate that one.

@simonhong
Copy link
Member

simonhong commented Jan 12, 2022

Below is our latest widevine permission bubble.
This one has additional footer area and it uses general site permission and Learn more link for all permission bubble.
Instead of this, how about customizing this footer area for widevine specific settings and learn more link?

Screen Shot 2022-01-12 at 3 00 39 PM

@simonhong
Copy link
Member

@rmcfadden3 @rebron How about this?
Screen Shot 2022-01-12 at 4 15 53 PM

@rmcfadden3
Copy link

@simonhong — that looks really good. The only thing I'd suggest is changing the order in the message footer, so it's clear that "Learn more" will tell you about Widevine, rather than settings in general. So the footer could read:

"[Learn more about Widevine](URL goes here). Change later at brave://settings/extensions."

@rmcfadden3
Copy link

BTW, I just checked in w/ Mattches to see about publishing a support doc so you have an endpoint URL for that "Learn more about Widevine" text.

simonhong added a commit to brave/brave-core that referenced this issue Jan 13, 2022
fix brave/brave-browser#9907

Permission bubble for widevine has custom footnote style.
simonhong added a commit to brave/brave-core that referenced this issue Jan 14, 2022
fix brave/brave-browser#9907

Permission bubble for widevine has custom footnote style.
@simonhong simonhong added this to the 1.36.x - Nightly milestone Jan 15, 2022
@stephendonner
Copy link

stephendonner commented Jan 18, 2022

Verified PASSED using

Brave 1.36.45 Chromium: 97.0.4692.71 (Official Build) nightly (x86_64)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. launched Brave
  3. loaded https://permission.site
  4. clicked on Encrypted Media (EME)
  5. looked at the resulting Widevine dialog
  • Confirmed the text change.
  • Confirmed the Learn more link goes to https://support.brave.com/hc/en-us/articles/360023851591-How-do-I-view-DRM-protected-content-
  • Confirmed the in-browser chrome link goes to brave://settings/extensions
before after
Screen Shot 2022-01-18 at 11 15 25 AM Screen Shot 2022-01-18 at 10 57 46 AM

Verified PASSED using

Brave 1.36.45 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Linux

Screen Shot 2022-01-18 at 5 45 00 PM


Verified PASSED using

Brave 1.36.46 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Windows 10 Version 20H2 (Build 19042.1466)

widevine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants