-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move widget stack state to list format #9584
Labels
Milestone
Comments
ryanml
added a commit
to brave/brave-core
that referenced
this issue
May 2, 2020
…nt from binary -> list
32 tasks
ryanml
added a commit
to brave/brave-core
that referenced
this issue
May 4, 2020
…nt from binary -> list
Blocked by #10067 |
This was referenced Jun 4, 2020
As discussed during the desktop planning and triage meeting, #10067 will be addressed in another. If it's fixed in time, we can get it into Lets run through as much as we can with the above cases and label this as verified. Removing the |
Verification passed on
Clean InstallWidget PositionToggleUpgrade InstallBoth widgets enabled
Both widgets disabled
Binance enabled Rewards disabled
Binance disabled Rewards enabled
Binance Widget stateVerification passed on
Clean InstallWidget PositionToggleUpgrade InstallBoth widgets enabled
Both widgets disabled
Binance enabled Rewards disabled
Binance disabled Rewards enabled
Binance Widget stateVerification passed on
Clean InstallWidget PositionToggleUpgrade InstallBoth widgets enabled
Both widgets disabled
Binance enabled Rewards disabled
Binance disabled Rewards enabled
Binance Widget state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently, the state of the widget stack on the NTP is binary:
This doesn't allow for ease of adding more widgets to it, which we plan to do. This attribute should be moved to a list, which is enumerated over and controls the display of the widgets in the stack. This will result in 0 change to the user experience, but will pave the way for the future widgets we plan to add. The piece of work should also migrate older states when upgrading to this new format.
Test Plan
brave://settings/newTab
works as expected.The text was updated successfully, but these errors were encountered: