Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use global top navigation bar for settings, rewards, history, bookmarks, downloads #956

Closed
rebron opened this issue Sep 4, 2018 · 2 comments · Fixed by brave/brave-core#1422
Closed

Use global top navigation bar for settings, rewards, history, bookmarks, downloads #956

rebron opened this issue Sep 4, 2018 · 2 comments · Fixed by brave/brave-core#1422
Assignees
@petemill @bsclifton
Labels
feature/global-settings Settings at browser level independent of shields settings priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.63.x - Release ...

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 4, 2018 •
edited
Loading

Description

Use global top navigation bar for:
chrome://settings
chrome://rewards
chrome://history
chrome://bookmarks/
chrome://downloads

Search widget should invoke the inline search function for the specific page i.e. if on Settings should search settings, if on Bookmarks should search Bookmarks.

Labels should be: "Search Settings", "Search History", "Search Bookmarks", "Search Downloads"

Design
@rebron rebron added this to the 1.0 milestone Sep 4, 2018
@rebron rebron added the feature/global-settings Settings at browser level independent of shields settings label Sep 5, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 15, 2019
@petemill
Copy link
Member

In lieu of a design which explains how this behaves with different width (tranlated) text and on different window sizes, I'm going to make the following assumptions in the implementation unless I hear otherwise:

  • The search box is a static width as shown in the mockup
  • We'll add the kebab to the right of the search box, as is currently on Bookmarks and History, and again fixed width
  • The titles take up the remaining width, up until the toolbar meets the window width, at which point the text will become truncated with ...

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@petemill petemill mentioned this issue Feb 15, 2019
Merged
21 tasks
petemill added a commit to brave/brave-ui that referenced this issue Feb 15, 2019
@petemill
Rewards on Desktop: Remove temporary header
467b65b 
Now that Brave-Core has its own Navigation Bar (implemented in brave/brave-core#1422), we can remove the temporary reserved area from the Rewards Views.
Required for brave/brave-browser#956
@petemill petemill mentioned this issue Feb 15, 2019
Merged
9 tasks
@bsclifton bsclifton added this to the 0.63.x - Nightly milestone Feb 22, 2019
@srirambv
Copy link
Contributor

srirambv commented Mar 25, 2019 •
edited by btlechowski
Loading

Verification passed on

Brave 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

Navigation Bar URL's
image

Custom checkboxes
image

Custom buttons
image

Typograpohy
image

Bookmarks (narrow Nav Bar)
image

Downloads (wide Nav Bar)
image

Extensions Nav Bar (with 'Developer Mode' submenu)
image

Verified passed with

Brave 0.63.21 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Verification passed on

Brave 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

image
image
image
image
image

@kjozwiak kjozwiak mentioned this issue Apr 24, 2019
Closed
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Sep 19, 2019
@petemill @NejcZdovc
Rewards: Imported from brave-ui: Rewards on Desktop: Remove temporary…
49615a5 
… header

Now that Brave-Core has its own Navigation Bar (implemented in #1422), we can remove the temporary reserved area from the Rewards Views.
Required for brave/brave-browser#956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

@bsclifton bsclifton

Labels
feature/global-settings Settings at browser level independent of shields settings priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

WebUI: Navigation Bar and other webui overhaul brave/brave-core
7 participants
@petemill @bbondy @bsclifton @rebron @srirambv @LaurenWags @btlechowski