Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement client side check for Binance errors #9498

Closed
srirambv opened this issue Apr 28, 2020 · 1 comment · Fixed by brave/brave-core#6685
Closed

Implement client side check for Binance errors #9498

srirambv opened this issue Apr 28, 2020 · 1 comment · Fixed by brave/brave-core#6685

Comments

@srirambv
Copy link
Contributor

Description

Implement client side check for Binance errors

Steps to Reproduce

  1. Connect to widget
  2. Try to convert asset
  3. Shows generic message that its not able to convert

Actual result:

image

Expected result:

Should provide details as to why the conversion failed

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1809 (Build 17763.1158)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @ryanml @bbondy

@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label May 1, 2020
@ryanml ryanml self-assigned this Sep 23, 2020
@ryanml ryanml added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Sep 23, 2020
@ryanml ryanml added this to the 1.16.x - Nightly milestone Sep 23, 2020
ryanml added a commit to brave/brave-core that referenced this issue Sep 24, 2020
deeppandya pushed a commit to brave/brave-core that referenced this issue Oct 7, 2020
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Linux
  • Verified client side check is done for failed transaction
    image

Verification passed on

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (x86_64)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS macOS Version 10.15.7 (Build 19H2)
  • Verified client side check is done for failed transaction
    image

Verification passed on

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Windows 10 OS Version 1809 (Build 17763.1490)
  • Verified client side check is done for failed transaction
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment