-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] "Learn more" is not the first option for Rewards or Binance widgets #9391
Comments
@LaurenWags Yeah, "Learn More" should come first. In general we should keep the most destructive action at the bottom of the widget menu if there are multiple actions provided. |
@karenkliu Understand what you're saying. Usual convention is actual functions first and help links towards the bottom. I get that this might work for the widget stack now but would it apply to other widgets like top sites as they change or even with the widget stack as they add more options. Inclined to do wontfix here. |
@rebron Yep, most destructive action "Hide" would also apply to other widgets as we add more options. The convention for UX design is to keep the most destructive action at the bottom - whether it's log out, delete account, delete X, or put something in trash. But this convention also carries over to other browsers. Here's some examples: Some non-browser examplesThe original designs for the widget menu had the most destructive action at the bottom due to this pervasive UX convention. It wasn't built per design spec so Lauren is correct to file the bug. Let's try to fix this issue. BTW, I'm not saying that destructive actions are never put at the top of menus - sometimes they are, because it's farthest from the user's thumb and the accessibility of least-used options is de-prioritized over more important actions (e.g. some iOS apps) but this widget menu is on desktop so that doesn't apply here. Also it's our browser so if we strongly prefer having destructive actions at the top of menus, we can do so. However it wouldn't follow users' mental models of where the most destructive action goes, which would detract from usability. |
…, hide is last, NTP widgets
Verified passed with
Verified STR from description Verification passed on
Verified STR from description |
Description
Per screenshots in #8883 (comment) I was expecting "Learn more" to be the first option for Rewards and Binance widgets, it is not.
@karenkliu if this is expected, please close this issue.
Steps to Reproduce
Actual result:
Expected result:
Learn more to be first option per #8883
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @ryanml
The text was updated successfully, but these errors were encountered: