Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] "Learn more" is not the first option for Rewards or Binance widgets #9391

Closed
LaurenWags opened this issue Apr 22, 2020 · 4 comments · Fixed by brave/brave-core#6784

Comments

@LaurenWags
Copy link
Member

Description

Per screenshots in #8883 (comment) I was expecting "Learn more" to be the first option for Rewards and Binance widgets, it is not.

@karenkliu if this is expected, please close this issue.

Steps to Reproduce

  1. Open NTP
  2. Click on ... icon on either Rewards or Binance widget

Actual result:

Screen Shot 2020-04-22 at 11 54 04 AM

Expected result:

Learn more to be first option per #8883

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @ryanml

@karenkliu
Copy link

@LaurenWags Yeah, "Learn More" should come first. In general we should keep the most destructive action at the bottom of the widget menu if there are multiple actions provided.

@rebron rebron self-assigned this Jun 5, 2020
@rebron rebron added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. priority/P4 Planned work. We expect to get to it "soon". and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Jun 12, 2020
@rebron
Copy link
Collaborator

rebron commented Jun 12, 2020

@karenkliu Understand what you're saying. Usual convention is actual functions first and help links towards the bottom. I get that this might work for the widget stack now but would it apply to other widgets like top sites as they change or even with the widget stack as they add more options.

Inclined to do wontfix here.

@karenkliu
Copy link

@rebron Yep, most destructive action "Hide" would also apply to other widgets as we add more options.

The convention for UX design is to keep the most destructive action at the bottom - whether it's log out, delete account, delete X, or put something in trash. But this convention also carries over to other browsers. Here's some examples:

Firefox
Screen Shot 2020-06-12 at 11 02 00 AM

Safari
Screen Shot 2020-06-12 at 11 03 55 AM

Screen Shot 2020-06-12 at 11 14 54 AM

Opera
Screen Shot 2020-06-12 at 11 04 00 AM

Microsoft Edge
Screen Shot 2020-06-12 at 11 05 34 AM

Screen Shot 2020-06-12 at 11 06 00 AM

Vivaldi
Screen Shot 2020-06-12 at 11 05 34 AM

Screen Shot 2020-06-12 at 11 06 56 AM

Some non-browser examples

Spotify
Screen Shot 2020-06-12 at 11 11 02 AM

Medium
Screen Shot 2020-06-12 at 11 11 07 AM

Airbnb
Screen Shot 2020-06-12 at 11 11 37 AM

Linkedin
Screen Shot 2020-06-12 at 11 13 03 AM
Screen Shot 2020-06-12 at 11 13 15 AM
Screen Shot 2020-06-12 at 11 18 11 AM

The original designs for the widget menu had the most destructive action at the bottom due to this pervasive UX convention. It wasn't built per design spec so Lauren is correct to file the bug. Let's try to fix this issue.

BTW, I'm not saying that destructive actions are never put at the top of menus - sometimes they are, because it's farthest from the user's thumb and the accessibility of least-used options is de-prioritized over more important actions (e.g. some iOS apps) but this widget menu is on desktop so that doesn't apply here. Also it's our browser so if we strongly prefer having destructive actions at the top of menus, we can do so. However it wouldn't follow users' mental models of where the most destructive action goes, which would detract from usability.

@srirambv srirambv changed the title "Learn more" is not the first option for Rewards or Binance widgets [Desktop] "Learn more" is not the first option for Rewards or Binance widgets Sep 9, 2020
@ryanml ryanml assigned ryanml and unassigned rebron Oct 6, 2020
@ryanml ryanml added this to the 1.17.x - Nightly milestone Oct 6, 2020
ryanml added a commit to brave/brave-core that referenced this issue Oct 6, 2020
@rebron rebron removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Oct 14, 2020
@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 28, 2020

Verified passed with

Brave | 1.17.53 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified STR from description

Screen Shot 2020-10-28 at 1 54 41 PM

Screen Shot 2020-10-28 at 1 54 53 PM


Verification passed on

Brave 1.17.68 Chromium: 87.0.4280.49 (Oficjalna wersja) (64-bitowa)
Wersja f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24544)

Verified STR from description

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants