Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show branded wallpaper notification in NTP for Super Referral #9329

Closed
simonhong opened this issue Apr 20, 2020 · 2 comments · Fixed by brave/brave-core#5290
Closed

Comments

@simonhong
Copy link
Member

simonhong commented Apr 20, 2020

Description

Notification for guiding about how to hide SI is only valid for Sponsored Images.
See https://bravesoftware.slack.com/archives/CT7JC4KBM/p1587357584128900

Test plan

  1. Do an install that uses Super Referral (put promoCode file in directory for TECHNIK; see Implement NTP Custom homepage ("super referral") brave-core#4866 for more steps)
  2. Launch into brave
  3. Enable rewards
  4. Pull up new tab until it shows super referral page
  5. Verify the rewards widget on NTP does NOT look like this:
    Screen Shot 2020-04-20 at 10 52 07 AM
@kjozwiak
Copy link
Member

kjozwiak commented Apr 28, 2020

Verification PASSED on macOS 10.15.4 x64 using the following build:

Brave | 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
-- | --
Revision | 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS | macOS Version 10.15.4 (Build 19E287)

Went through the STR outlined under #9329 and ensured that the You're getting paid to view this background image message wasn't being displayed in the Rewards modal under the NTP:

Screen Shot 2020-04-28 at 2 48 44 AM

Screen Shot 2020-04-28 at 2 48 53 AM

Screen Shot 2020-04-28 at 2 49 04 AM

Also ensured that the You're getting paid to view this background image was still being displayed when a user enabled Rewards that's going through the normal NTP SI flow:

Screen Shot 2020-04-28 at 2 49 56 AM

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Went through the STR outlined under #9329 and ensured that the You're getting paid to view this background image message wasn't being displayed in the Rewards modal under the NTP:

image
image
image

@btlechowski
Copy link

Setting as OS/Windows and OS/macOS because referrals are unavailable on Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment