Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noopener should be in use for opening Binance auth and referral URLs #9317

Closed
ryanml opened this issue Apr 18, 2020 · 1 comment · Fixed by brave/brave-core#5286
Closed

noopener should be in use for opening Binance auth and referral URLs #9317

ryanml opened this issue Apr 18, 2020 · 1 comment · Fixed by brave/brave-core#5286
Assignees
@ryanml
Labels
feature/new-tab feature/widgets QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude sec-low
Milestone
1.8.x - Release

Comments

@ryanml
Copy link
Contributor

ryanml commented Apr 18, 2020

Per sec review comments here: brave/brave-core#5160 (review) we should be using noopener for the Binance referral and authorization URLs. Also, some validation should be performed before setting the clientUrl.

For QA, there should be no change in functionality, rather a regression test should be performed for the auth process and the buy links.
@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 18, 2020
@ryanml ryanml self-assigned this Apr 18, 2020
@ryanml ryanml mentioned this issue Apr 18, 2020
Merged
32 tasks
ryanml added a commit to brave/brave-core that referenced this issue Apr 19, 2020
@ryanml
Fixes brave/brave-browser#9317 - Uses noopener for Binance URLs, clie…
a8bd192 
…nt url validation
@ryanml ryanml mentioned this issue Apr 20, 2020
Merged
4 tasks
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1909 (Build 18363.778)
  • Verified able to connect to widget successfully
  • Verified hide/unhide functionality works fine
  • Verified asset address/QR code shows correctly
  • Verified convert functionality works fine
  • Verified hiding widget via menu or dashboard successfully disconnects the widget
  • Verified ref code correctly auto-populated on the buy landing page

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified able to connect to widget successfully
  • Verified hide/unhide functionality works fine
  • Verified asset address/QR code shows correctly
  • Verified convert functionality works fine
  • Verified hiding widget via menu or dashboard successfully disconnects the widget
  • Verified ref code correctly auto-populated on the buy landing page

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Linux
  • Verified able to connect to widget successfully
  • Verified hide/unhide functionality works fine
  • Verified asset address/QR code shows correctly
  • Verified convert functionality works fine
  • Verified hiding widget via menu or dashboard successfully disconnects the widget
  • Verified ref code correctly auto-populated on the buy landing page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/new-tab feature/widgets QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude sec-low
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging a pull request may close this issue.

Uses noopener for Binance URLs, client url validation brave/brave-core
4 participants
@kjozwiak @ryanml @srirambv @LaurenWags