Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Binance widget should be accessible via tab index #9256

Closed
srirambv opened this issue Apr 16, 2020 · 1 comment · Fixed by brave/brave-core#5572
Closed

[Desktop] Binance widget should be accessible via tab index #9256

srirambv opened this issue Apr 16, 2020 · 1 comment · Fixed by brave/brave-core#5572

Comments

@srirambv
Copy link
Contributor

Description

Binance widget should be accessible via tab index

Steps to Reproduce

  1. Connect Binance widget
  2. Open a new tab
  3. Press tab to select the next element
  4. Binance widget isn't focused as there is no input filed in summary view

Actual result:

Binance widget isn't accessible via tab index

Expected result:

Binance widget should be accessible via tab index

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv
Copy link
Contributor Author

srirambv commented Jun 29, 2020

Verification passed on

Brave 1.11.77 Chromium: 83.0.4103.116 (Official Build) beta (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{# 716}
OS Linux

Verification passed on

Brave 1.11.77 Chromium: 83.0.4103.116 (Official Build) beta (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{# 716}
OS Windows 10 OS Version 1809 (Build 17763.379)
  • Verified Binance widget is accessible through tab index

Verification passed on

Brave 1.11.77 Chromium: 83.0.4103.116 (Official Build) beta (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{# 716}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified Binance widget is accessible through tab index

@rebron rebron changed the title Binance widget should be accessible via tab index [Desktop] Binance widget should be accessible via tab index Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants