Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment made text needs to be updated in Monthly statements #8960

Closed
GeetaSarvadnya opened this issue Apr 1, 2020 · 4 comments · Fixed by brave/brave-core#5644
Closed

Payment made text needs to be updated in Monthly statements #8960

GeetaSarvadnya opened this issue Apr 1, 2020 · 4 comments · Fixed by brave/brave-core#5644

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 1, 2020

Description

Payment made text needs to be updated in Monthly statements

Steps to Reproduce

  1. Clean profile 1.7.79
  2. Setup a recurring tip
  3. Send a one time tip
  4. Trigger AC and check the monthly statement for Auto-Contribute
  5. The text Payment made every 1th each month is displayed - this needs to rephrased to Payment made on every 1st of each month

Actual result:

image

Expected result:

The text needs to be rephrased to Payment made on every 1st of each month

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.7.81 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

@NejcZdovc
Copy link
Contributor

@mandar-brave @jenn-rhim do we even need this text?

@NejcZdovc NejcZdovc added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed bug labels Apr 10, 2020
@rebron rebron added needs-text-change This change requires some careful wording. OS/Desktop labels May 22, 2020
@rebron
Copy link
Collaborator

rebron commented May 22, 2020

@mandar-brave I think this text can be removed. You already have Next Payment date on the main Rewards page.

@mandar-brave
Copy link

Yes. Makes sense. @NejcZdovc @rebron

@NejcZdovc NejcZdovc self-assigned this May 25, 2020
@NejcZdovc NejcZdovc added this to the 1.11.x - Nightly milestone May 25, 2020
@NejcZdovc NejcZdovc removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. needs-text-change This change requires some careful wording. labels May 25, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue May 25, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jun 16, 2020

Verified passed with

Brave 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-06-16 at 8 21 38 AM

Screen Shot 2020-06-16 at 8 21 48 AM

Screen Shot 2020-06-16 at 8 21 56 AM


Verification passed on

Brave | 1.11.68 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | Windows 10 OS Version 1903 (Build 18362.30)


Verified passed with

Brave	1.11.84 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux

Screen Shot 2020-07-01 at 11 05 57 AM

Screen Shot 2020-07-01 at 11 06 07 AM

Screen Shot 2020-07-01 at 11 06 23 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment