Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check failure while importing from welcome page #8808

Closed
simonhong opened this issue Mar 23, 2020 · 1 comment · Fixed by brave/brave-core#5018
Closed

Check failure while importing from welcome page #8808

simonhong opened this issue Mar 23, 2020 · 1 comment · Fixed by brave/brave-core#5018

Comments

@simonhong
Copy link
Member

simonhong commented Mar 23, 2020

Description

Crashed with master build (Version 1.8.32 Chromium: 81.0.4044.69 (Developer Build) (64-bit))

[47456:47456:0323/135125.549138:FATAL:import_data_handler.cc(116)] Check failed: args->GetDictionary(1, &types). 
#0 0x7f2dfa3f882f base::debug::CollectStackTrace()
#1 0x7f2dfa11444d base::debug::StackTrace::StackTrace()
#2 0x7f2dfa114408 base::debug::StackTrace::StackTrace()
#3 0x7f2dfa15a21d logging::LogMessage::~LogMessage()
#4 0x56514c25099b settings::ImportDataHandler::HandleImportData()
#5 0x56514c252bdb base::internal::FunctorTraits<>::Invoke<>()
#6 0x56514c252ac6 base::internal::InvokeHelper<>::MakeItSo<>()

Test plan / Steps to reproduce

  1. Launch browser and load brave://welcome
  2. Try to import from any profile
  3. Importing should be done w/o crash
@LaurenWags
Copy link
Member

LaurenWags commented Apr 10, 2020

Verified passed with

Brave 1.8.71 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from description
  • Confirmed history and bookmarks imported from Firefox using brave://welcome (note, encountered logged issue Passwords, Search Engine, and Autofill are not imported from Firefox #2198)
  • Confirmed history, bookmarks, and passwords were imported from Chrome using brave://welcome.
  • Confirmed no crashes observed when importing from brave://welcome

Verification passed on

Brave 1.8.72 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Ubuntu 18.04 LTS
  • Verified test plan from description
  • Verified history and bookmarks imported from Firefox using brave://welcome
  • Verified history, bookmarks, and passwords were imported from Chrome using brave://welcome.

Verification passed on

Brave 1.8.77 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description
  • Verified history and bookmarks imported from Firefox using brave://welcome
  • Verified history, bookmarks, and passwords were imported from Chrome using brave://welcome.

Verification passed on

Brave 1.8.77 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description
  • Verified history and bookmarks imported from Firefox using brave://welcome
  • Verified history, bookmarks, and passwords were imported from Chrome using brave://welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment