Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lost pinned top sites on NTP upon upgrade #8781

Closed
rebron opened this issue Mar 20, 2020 · 1 comment · Fixed by brave/brave-core#4996 or brave/brave-core#5097
Closed

lost pinned top sites on NTP upon upgrade #8781

rebron opened this issue Mar 20, 2020 · 1 comment · Fixed by brave/brave-core#4996 or brave/brave-core#5097

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 20, 2020

Description

Using 1.8.25 and upgrading via download/install of 1.8.28 (but likely in 1.8.27 also), 3 pinned tabs disappear upon relaunch. Expectation is that those pinned tabs and all tabs remain the same after upgrading. Subsequent attempts to reload or open new brave://newtab don't bring them back.

Test plan / Steps to Reproduce

  1. Older profile. Pin 2 or 3 top sites on the New Tab Page brave://newtab
  2. Download 1.8.27 or 1.8.28
  3. Notice that the pinned top tiles are missing.

Actual result:

Screen Shot 2020-03-20 at 8 20 37 AM

Expected result:

Screen Shot 2020-03-20 at 8 19 53 AM

Reproduces how often:

Might be difficult to reproduce.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? 1.8.27 and higher

Miscellaneous Information:

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 20, 2020
@bsclifton bsclifton added this to the 1.8.x - Nightly milestone Mar 20, 2020
cezaraugusto added a commit to brave/brave-core that referenced this issue Mar 27, 2020
Fix brave/brave-browser#8781
Top sites (now called grid sites) now have their
own storage. This change allows the migration
process from a shared to a dedicated storage.
cezaraugusto added a commit to brave/brave-core that referenced this issue Mar 30, 2020
Fix brave/brave-browser#8781
Top sites (now called grid sites) now have their
own storage. This change allows the migration
process from a shared to a dedicated storage.
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 17, 2020

Verification passed on

Brave 1.8.79 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Verification passed on

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment