Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use webpack to solve browser field issue in webtorrent and bittorrent-tracker #856

Closed
yrliou opened this issue Aug 27, 2018 · 0 comments · Fixed by brave/brave-core#3134
Closed

Use webpack to solve browser field issue in webtorrent and bittorrent-tracker #856

yrliou opened this issue Aug 27, 2018 · 0 comments · Fixed by brave/brave-core#3134
Assignees
@feross
Labels
feature/webtorrent Label for webtorrent related issues QA/No release-notes/exclude
Milestone
0.69.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Aug 27, 2018 •
edited
Loading

For initial support of WebTorrent implemented by brave/brave-core#356, we fork these two repos because they uses browser field in their package.json to exclude some modules in browser targets which we would like to include instead.
In the long-term, we should modify webpack config and add necessary shimming APIs to avoid forking them.

repos:
https://github.com/brave/webtorrent
https://github.com/brave/bittorrent-tracker
https://github.com/brave/torrent-discovery
@yrliou yrliou added the feature/webtorrent Label for webtorrent related issues label Aug 27, 2018
@bbondy bbondy added this to the Backlog milestone Aug 29, 2018
@yrliou yrliou mentioned this issue Sep 10, 2018
Merged
11 tasks
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@feross feross self-assigned this Jul 23, 2019
@feross feross mentioned this issue Jul 30, 2019
Merged
32 tasks
@feross feross mentioned this issue Aug 8, 2019
Closed
@feross feross mentioned this issue Aug 9, 2019
Merged
32 tasks
@feross feross added the QA/No label Aug 9, 2019
feross added a commit to brave/brave-core that referenced this issue Aug 9, 2019
@feross
Depend on upstream WebTorrent
d187598 
Fixes: brave/brave-browser#5587
Fixes: brave/brave-browser#856
Fixes: brave/brave-browser#5489

This makes Brave depend on upstream WebTorrent instead of the fork. This also removes the need for forks of torrent-discovery and bittorrent-tracker.
@feross feross added this to the 0.70.x - Nightly milestone Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feross feross

Labels
feature/webtorrent Label for webtorrent related issues QA/No release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Depend on upstream WebTorrent brave/brave-core
5 participants
@feross @bbondy @yrliou @rebron @LaurenWags