-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] brave://bookmarks tab icon uses a star icon instead of Brave bookmarks icon - follow up to 2494 #8492
Labels
branding
bug
feature/bookmarks
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
rebron
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Apr 17, 2020
@karenkliu Can we get an icon for this one? This one has been bothering me too. |
Need icon for above similar to: I think #7312 are for the folder icons no? |
@rebron Oops, sorry you're right, that's a different issue. Actually the one you need in the tab title is probably this icon: Here you go! |
32 tasks
WebUI's favicon is determined by |
32 tasks
3 tasks
rebron
changed the title
brave://bookmarks tab icon uses star icon instead of Brave bookmarks icon - follow up to 2494
[Desktop] brave://bookmarks tab icon uses a star icon instead of Brave bookmarks icon - follow up to 2494
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
branding
bug
feature/bookmarks
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Description
Per #2494 (comment) we should also address the favicon in the brave://bookmarks tab and use our own branded icon instead of the star icon.
Steps to Reproduce
Actual result:
See star icon on tab
Expected result:
Tab favicon should show our own branded icon, not the star icon
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: