-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Brave branded icons for Bookmarks manager #7312
Comments
I suspect this is the correct issue to post this - I'm observing a folder icon in brave://bookmarks in the left panel that appears a bit out of place. Would expect to see an icon that matches the Bookmarks icon at the top of the Bookmarks page.
I'm on Fedora 31 |
cc: @karenkliu |
This is our own bookmarks folder icon: It replaces the Chrome bookmarks folder icon in the browser toolbar and on chrome://bookmarks/ Icon asset: Also, is this issue related to #6013? |
@karenkliu, Below images are needed for bookmark folder.
Note - Upstream mac only uses closed image. Others are uses open/closed images. |
Hi @simonhong, here is the direct link to our bookmarks icon in Figma where you can export it as a PNG in all the needed sizes: https://www.figma.com/file/xWGBM3qWbu3RLuZqZGwynk/Icons?node-id=124%3A10713 |
This issue needs more changes and efforts than expected because upstream on window and linux don't use different images for folder open/closed. They use same yellow colored folder images for dark/light theme. |
Description
Match the icons added for Bookmarks Toolbar here:
brave/brave-core#10037
For more info, see https://www.figma.com/file/sS3l8tqUFxt54MEiBTalUI/?node-id=9%3A5824
Should look like this:
Original issue description
Use Brave branded icons for history. More info here #6013 (comment)
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: