Ads service shows "Failed to load" error on startup

[jonathanKingston]

I keep seeing these perpetual errors when stating up an existing Brave profile.

[8507:8549:0207/230115.308801:ERROR:ads_service_impl.cc(211)] Failed to read file: /home/jonathan/.config/BraveSoftware/Brave-Browser-Development/Default/ads_service/notifications.json
[8541:1:0207/230115.309032:ERROR:notifications.cc(301)] Failed to load notifications state, resetting to default values
[8507:8549:0207/230115.309281:ERROR:ads_service_impl.cc(211)] Failed to read file: /home/jonathan/.config/BraveSoftware/Brave-Browser-Development/Default/ads_service/ad_conversions.json
[8541:1:0207/230115.309433:ERROR:ad_conversion_tracking.cc(279)] Failed to load ad conversions state, resetting to default values

It appears that it should be saving the state when there isn't one.

[btlechowski]

Verification passed on

Brave	1.7.70 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4560
On clean profile

[13963:13963:0324/034758.059885:ERROR:confirmations_impl.cc(777)] Failed to load confirmations state, resetting to default values
[13964:1:0324/034808.459457:ERROR:client.cc(682)] Failed to load client state, resetting to default values
[13964:1:0324/034808.466720:ERROR:ad_notifications.cc(324)] Failed to load notifications state, resetting to default values
[13964:1:0324/034808.480881:ERROR:ad_conversions.cc(281)] Failed to load ad conversions state, resetting to default values

Verified errors are not shown after restart

Verification passed on

Brave	1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from Persist native Brave Ads storage on a new profile brave-core#4560
• Verified that Failed to load client state, resetting to default values log is only shown in the console once after a fresh install, and not after subsequent launches of the application

[14852:17972:0324/153834.311:ERROR:client.cc(682)] Failed to load client state, resetting to default values

• Verified that "Failed to load notifications state, resetting to default values" log is only shown in the console once after a fresh install, and not after subsequent launches of the application

[13640:17360:0324/160834.503:ERROR:ad_notifications.cc(324)] Failed to load notifications state, resetting to default values

• Verified that "Failed to load ad conversions state, resetting to default values" log is only shown in the console once after a fresh install, and not after subsequent launches of the application

[10164:10232:0324/161847.626:ERROR:ad_conversions.cc(281)] Failed to load ad conversions state, resetting to default values

• Verified that "Failed to load confirmations state, resetting to default values" log is only shown in the console once after a fresh install, and not after subsequent launches of the application

[1976:7240:0324/165752.193:ERROR:confirmations_impl.cc(777)] Failed to load confirmations state, resetting to default values

---

Verified passed with

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from Persist native Brave Ads storage on a new profile brave-core#4560

• Confirmed that Failed to load client state, resetting to default values log is only shown in the terminal once after a fresh install, and not after subsequent launches of the application.

[9477:775:0330/092150.772852:ERROR:client.cc(682)] Failed to load client state, resetting to default values

• Confirmed that Failed to load notifications state, resetting to default values log is only shown in the terminal once after a fresh install, and not after subsequent launches of the application.

[9477:775:0330/092150.784893:ERROR:ad_notifications.cc(324)] Failed to load notifications state, resetting to default values

• Confirmed that Failed to load ad conversions state, resetting to default values log is only shown in the terminal once after a fresh install, and not after subsequent launches of the application.

[9477:775:0330/092150.795740:ERROR:ad_conversions.cc(281)] Failed to load ad conversions state, resetting to default values

• Confirmed that Failed to load confirmations state, resetting to default values log is only shown in the terminal once after a fresh install, and not after subsequent launches of the application.

[9476:775:0330/092141.504873:ERROR:confirmations_impl.cc(777)] Failed to load confirmations state, resetting to default values